If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix broken controller usage in TabbedBrowsingAPI

RESOLVED FIXED

Status

Product:
Mozilla QA
Component:
Mozmill Tests
RESOLVED FIXED
Reported:
7 years ago
Modified:
7 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 attachment)

Patch v1
2.83 KB, patch
aaronmt
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
7 years ago 
In the TabbedBrowsingAPI we are using a controller variable while we would have to use this._controller. I haven't seen a failure for those specific failures so far. But lets get this fixed.
 (Assignee)

Updated

•
7 years ago
Whiteboard: [mozmill-test-failure]
 (Assignee)

Comment 1

•
7 years ago 
Created attachment 481486 [details] [diff] [review]
Patch v1
Attachment #481486 - Flags: review?(aaron.train)

Comment 2

•
7 years ago 
Comment on attachment 481486 [details] [diff] [review]
Patch v1

Makes sense. Thanks, r+
Attachment #481486 - Flags: review?(aaron.train) → review+
 (Assignee)

Comment 3

•
7 years ago 
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/e5d28b9aa68d (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/4e30174c0881 (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/28e3a65f7fda (mozilla1.9.1)
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
 (Assignee)

Comment 4

•
7 years ago 
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Tests
Product: Testing → Mozilla QA
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.