Closed Bug 602532 Opened 12 years ago Closed 12 years ago

Context menu items on new titlebar are wrong status

Categories

(Core :: Widget: Win32, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0
Tracking Status
blocking2.0 --- final+

People

(Reporter: alice0775, Assigned: jimm)

References

Details

Attachments

(1 file, 1 obsolete file)

Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre ID:20101007042624

Context manu items on new titiebar are wrong status


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Maxmize and Right click on the new titlebar
)
3. Restore Nomal and  Right click on the new titlebar

Actual Results:
 Context manu items on new titiebar are wrong status

Expected Results:
  In normal mode, Restore.. should be disabled.
  In Maximozed mode, Move, Resize, Maximize should be disabled.
blocking2.0: --- → ?
Target Milestone: --- → mozilla2.0
Summary: Context manu items on new titiebar are wrong status → Context menu items on new titiebar are wrong status
Summary: Context menu items on new titiebar are wrong status → Context menu items on new titlebar are wrong status
Depends on: 602450
Attached patch patch (obsolete) — Splinter Review
Ok, I'm seeing this. Very random, I guess the system doesn't maintain the menu, it just hands us whatever menu it currently has. That results in random behavior.  This patch resets the system menu and manually updates it's options before displaying it.
Assignee: nobody → jmathies
Comment on attachment 481604 [details] [diff] [review]
patch

Neil, mind looking this one over too? Pretty straight forward change.
Attachment #481604 - Flags: review?(neil)
Attached patch patchSplinter Review
minor update - minimize needs it's own options. I'm not sure if you can bring this up on a minimized window, but what the heck.
Attachment #481604 - Attachment is obsolete: true
Attachment #481610 - Flags: review?(neil)
Attachment #481604 - Flags: review?(neil)
Comment on attachment 481610 [details] [diff] [review]
patch

>+            case nsSizeMode_Fullscreen:
[The "real" system menu behaves oddly in this case; it enables the items as if the window wasn't full screen, except that Size is always disabled. There's probably a bug filed that the Restore/Maximize items don't work anyway.]
Attachment #481610 - Flags: review?(neil) → review+
blocking2.0: ? → final+
http://hg.mozilla.org/mozilla-central/rev/6969aecdf531
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Comment on attachment 481610 [details] [diff] [review]
> patch
> 
> >+            case nsSizeMode_Fullscreen:
> [The "real" system menu behaves oddly in this case; it enables the items as if
> the window wasn't full screen, except that Size is always disabled. There's
> probably a bug filed that the Restore/Maximize items don't work anyway.]

bug 580564
You need to log in before you can comment on or make changes to this bug.