602532 - Context menu items on new titlebar are wrong status

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre ID:20101007042624

Context manu items on new titiebar are wrong status


Reproducible: Always

Steps to Reproduce:
1. Start Minefield with new profile
2. Maxmize and Right click on the new titlebar
)
3. Restore Nomal and  Right click on the new titlebar

Actual Results:
 Context manu items on new titiebar are wrong status

Expected Results:
  In normal mode, Restore.. should be disabled.
  In Maximozed mode, Move, Resize, Maximize should be disabled.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Ok, I'm seeing this. Very random, I guess the system doesn't maintain the menu, it just hands us whatever menu it currently has. That results in random behavior.  This patch resets the system menu and manually updates it's options before displaying it.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 481604 [details] [diff] [review]
patch

Neil, mind looking this one over too? Pretty straight forward change.

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

minor update - minimize needs it's own options. I'm not sure if you can bring this up on a minimized window, but what the heck.

Comment 4

[[e-mail]]

Comment on attachment 481610 [details] [diff] [review]
patch

>+            case nsSizeMode_Fullscreen:
[The "real" system menu behaves oddly in this case; it enables the items as if the window wasn't full screen, except that Size is always disabled. There's probably a bug filed that the Restore/Maximize items don't work anyway.]

Comment 5

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/6969aecdf531

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #4)
> Comment on attachment 481610 [details] [diff] [review]
> patch
> 
> >+            case nsSizeMode_Fullscreen:
> [The "real" system menu behaves oddly in this case; it enables the items as if
> the window wasn't full screen, except that Size is always disabled. There's
> probably a bug filed that the Restore/Maximize items don't work anyway.]

bug 580564