602535 - in download manager, change "Remove" button to "Delete" button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

We should change the button label in the download manager from "Remove" to "Delete."  Delete is more consistently associated with what the button actually does here (deletes the file from the filesystem);  "Remove" is a holdover from the desktop product, where the button just removes the line from the download manager.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Change text, add prompt

This changes the text and also adds a "Delete" prompt that we have talked about on IRC.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 481555 [details] [diff] [review]
Change text, add prompt


>+downloadsDeleteTitle=Delete File
>+downloadsDeleteMessage=Are you sure you want to delete %S?
>+downloadsDeleteButtonTitle=Delete

Looks good, but I am not sure about the strings for the confirmation dialog. It just seems too "wordy"

Do we need a title and a long message? Could we just use the filename as the message:

   Delete File
-----------------
    filename

[Delete] [Cancel]



Madhava?

Comment 3

[Madhava Enros [:madhava]]

Let's mimic the Android convention that uses "OK" and "Cancel" rather than other verbs for the action button.

so:

Delete File
filename
[OK] [Cancel]

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds good. Wes, I think you can simplify the prompt code if we use standard OK/Cancel

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch V2

Fixes

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/44688aeda4fd

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101011 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101011 Namoroka/4.0b8pre Fennec/4.0b2pre

Comment 8

[Ayan Shah[:ashah]]

Litmus test case - https://litmus.mozilla.org/show_test.cgi?id=12268