Closed Bug 602572 Opened 12 years ago Closed 12 years ago
Log request and response bodies checkbox issues in Web Console
STR: 1. Open the Web Console. 2. Enable log request and response bodies (right-click). 3. Close the Web Console. 4. Reopen the Web Console. 5. Refresh the web page. 6. Click a network request log. Expected result: the response body is not logged. Actual result: the response body is logged. The menitem falsely shows the option is disabled checkbox. STR 2: 1. Open tabA and the Web Console inside it. 2. Open tabB and the Web Console inside it. 3. Enable logging of request and response bodies in tabA. 4. Refresh the Web Console inside tabB. 5. Click a network request log. Expected result: the network response body is not logged. Actual result: the network response body is logged.
I can see where this behavior comes from, but I agree that it's inconsistent and confusing. At the very least, the checkbox should show the true state of request/response body logging. Also, if request/response body logging is tracked on a per site basis, we should turn it off when you close the console. Otherwise, people might have their memory consumed without knowing why (and the only way to stop it is to restart the browser or reopen the console on the right site and disable the logging...)
Assignee: nobody → mihai.sucan
OK, looking at the patch in bug 598851, it appears that the logging is not tracked per site. So, we really just need to make sure that the check mark in the menu is always consistent.
Attachment #484652 - Flags: feedback?(rcampbell)
Status: NEW → ASSIGNED
Comment on attachment 484652 [details] [diff] [review] proposed patch I don't see a corresponding menuPopup.removeEventListener in here. Do we do proper destruction of all these xul elements when we shutdown?
(In reply to comment #4) > Comment on attachment 484652 [details] [diff] [review] > proposed patch > > I don't see a corresponding menuPopup.removeEventListener in here. Do we do > proper destruction of all these xul elements when we shutdown? Yes, we do that in unregisterDisplay().
Requesting blocking for this bug. The "Log request and response bodies" checkbox in the context menu does not always show the true state of that logging, which would certainly be very confusing for the user.
blocking2.0: --- → ?
Blocking+ for broken UI.
blocking2.0: ? → final+
Comment on attachment 484652 [details] [diff] [review] proposed patch yup
Attachment #484652 - Flags: feedback?(rcampbell) → feedback+
Updated patch. Rebased and made small fixes needed. Thanks Robert for the feedback+!
Whiteboard: [patchclean:1020] → [patchclean:1117]
mass change: filter on PRIORITYSETTING
Priority: -- → P1
mass change: filter mail on BLOCKERSETTING
Severity: normal → blocker
Comment on attachment 491202 [details] [diff] [review] updated patch Normally this could be done with XUL observers, but I guess that's kind of awkward here since the DOM's constructed via JS.
Attachment #491202 - Flags: review?(dolske) → review+
Rebased patch. Thanks for the review+!
Attachment #491202 - Attachment is obsolete: true
Whiteboard: [patchclean:1117] → [patchclean:0101][checkin]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
You need to log in before you can comment on or make changes to this bug.