Closed Bug 602674 Opened 9 years ago Closed 9 years ago

Create an Android theme for popups

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0b2+)

VERIFIED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: vingtetun, Assigned: mbrubeck)

References

()

Details

Attachments

(7 files, 2 obsolete files)

see attached url.

By popups, I mean the Alert/Prompt/Confirm and also the notifications and Bookmark edit popup/New Tab popup
tracking-fennec: --- → 2.0b2+
Attached patch wip (obsolete) — Splinter Review
This patch:
* Adds arrow popup support to the bookmark edit popup
* Adds some fixes to the arrowbox.xml binding
Assignee: nobody → mark.finkle
Madhava - feedback wanted!
I was thinking that we'd use rows, like with the new larry or search providers design rather than our older style buttons.
Yes, I'd use the assets I cut for the Larry panels for these.
This builds on Mark's WIP patch to make the bookmark popup an arrowbox.  It adds the following:

* Use Sean's background gradient image for arrowboxes and prompts.
* Make site menu buttons and prompt buttons transparent (with the new image for the active state background).
* Bottom buttons in site menu and prompts are no longer styled differently.
* Make the transparent background mask darker to match Android native style.

Still to do:

* Apply the new button style to the bookmark popup.
* Apply the new popup style to context menus, notifications, and menulists.
Assignee: mark.finkle → mbrubeck
Attachment #483801 - Attachment is obsolete: true
Attachment #483802 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #484400 - Flags: review?(mark.finkle)
Attached image dialog screenshot
Attached image arrowbox screenshot
Attachment #484400 - Flags: review?(mark.finkle) → review+
This is rough, but I think it's good for b2.  Some things left to do, possibly in followup for b3:

* Make headers or title white-on-dark (like native Android dialogs) for prompts and context menus.
* Give the "new tab" notification an arrowbox arrow, pointing toward the tab bar.
Attachment #484876 - Flags: review?(mark.finkle)
Comment on attachment 484876 [details] [diff] [review]
part 2: Context menu, notifications

Good to land for b2. If we get time, the dark headers would be higher priority than the arrowbox, imo.
Attachment #484876 - Flags: review?(mark.finkle) → review+
Pushed: http://hg.mozilla.org/mobile-browser/rev/51afad23f92c

I'm going to mark this fixed; we can do further work in followup bugs.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified on Build:

Mozilla/5.0(Android; Linux armv7l; rv:2.0b8pre) Gecko/20101021 Firefox/4.0b8pre
Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.