If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Create an Android theme for popups

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: vingtetun, Assigned: mbrubeck)

Tracking

Details

(URL)

Attachments

(7 attachments, 2 obsolete attachments)

see attached url.

By popups, I mean the Alert/Prompt/Confirm and also the notifications and Bookmark edit popup/New Tab popup
No longer depends on: 575403
tracking-fennec: --- → 2.0b2+
Created attachment 483801 [details] [diff] [review]
wip

This patch:
* Adds arrow popup support to the bookmark edit popup
* Adds some fixes to the arrowbox.xml binding
Assignee: nobody → mark.finkle
Created attachment 483802 [details]
bookmark popup screenshot
Madhava - feedback wanted!
I was thinking that we'd use rows, like with the new larry or search providers design rather than our older style buttons.

Comment 5

7 years ago
Yes, I'd use the assets I cut for the Larry panels for these.
(Assignee)

Comment 6

7 years ago
Created attachment 484400 [details] [diff] [review]
part 1: arrowbox and dialog styles

This builds on Mark's WIP patch to make the bookmark popup an arrowbox.  It adds the following:

* Use Sean's background gradient image for arrowboxes and prompts.
* Make site menu buttons and prompt buttons transparent (with the new image for the active state background).
* Bottom buttons in site menu and prompts are no longer styled differently.
* Make the transparent background mask darker to match Android native style.

Still to do:

* Apply the new button style to the bookmark popup.
* Apply the new popup style to context menus, notifications, and menulists.
Assignee: mark.finkle → mbrubeck
Attachment #483801 - Attachment is obsolete: true
Attachment #483802 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #484400 - Flags: review?(mark.finkle)
(Assignee)

Comment 7

7 years ago
Created attachment 484402 [details]
dialog screenshot
(Assignee)

Comment 8

7 years ago
Created attachment 484403 [details]
arrowbox screenshot
Attachment #484400 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 9

7 years ago
Pushed part 1: http://hg.mozilla.org/mobile-browser/rev/f604d63e84b9
(Assignee)

Comment 10

7 years ago
Created attachment 484876 [details] [diff] [review]
part 2: Context menu, notifications

This is rough, but I think it's good for b2.  Some things left to do, possibly in followup for b3:

* Make headers or title white-on-dark (like native Android dialogs) for prompts and context menus.
* Give the "new tab" notification an arrowbox arrow, pointing toward the tab bar.
Attachment #484876 - Flags: review?(mark.finkle)
(Assignee)

Comment 11

7 years ago
Created attachment 484878 [details]
screenshot: desktop/Maemo notification
(Assignee)

Comment 12

7 years ago
Created attachment 484879 [details]
screenshot: new tab notification
(Assignee)

Comment 13

7 years ago
Created attachment 484880 [details]
screenshot: context menu
Comment on attachment 484876 [details] [diff] [review]
part 2: Context menu, notifications

Good to land for b2. If we get time, the dark headers would be higher priority than the arrowbox, imo.
Attachment #484876 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 15

7 years ago
Pushed: http://hg.mozilla.org/mobile-browser/rev/51afad23f92c

I'm going to mark this fixed; we can do further work in followup bugs.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 16

7 years ago
Verified on Build:

Mozilla/5.0(Android; Linux armv7l; rv:2.0b8pre) Gecko/20101021 Firefox/4.0b8pre
Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.