60268 - Previous search text in find dialog should be selected when opened

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Adam Lock]

If you open the find dialog (e.g. ctrl+f) the search field contains the value 
used by the previous search. This value should be highlighted so that you can 
replace the old value just by starting to type. The current implementation does 
not select the field so that to replace the old value you must delete it first.

One line patch follows.

Comment 1

[Adam Lock]

Attachment: 1 line patch selects the value when the find dialog is opened. Review and comments please!

Comment 2

[sairuh (rarely reading bugmail)]

simon/bill?

Comment 3

[Bill Law]

The patch looks good.  I need to test it out to make sure it works right in the
case where the find dialog is already open vs. when it isn't (fixing that might
take a bit more code).

BTW, there's a dup of this bug (Dave Hyatt opened it a little while ago).

Comment 4

[sairuh (rarely reading bugmail)]

*** Bug 46927 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

found the earlier bug... marked it a dup of this, since this one has a patch
attached.

Comment 6

[Adam Lock]

Bill, can you try your test case? I'm eager to checkin this bug if all looks well...

Comment 7

[Bill Law]

Attachment: Alternative fix that selects when onfocus occurs

Comment 8

[Bill Law]

The only test I did was to try Ctrl-F to bring up the dialog.  Then, click on
the web page so focus goes away from the dialog.  Then, press Ctrl-F again.
This brings the dialog into focus but because it isn't opened anew, the search
field does not get the focus.

I've modified your patch so that the selection is set on the onfocus event.
This also has the "feature" that if you tab through the dialog contents, the
contents of the field are selected if you tab into that field from the buttons.

This seems better to me.  I don't see why there should be different behavior
when the dialog is already visible versus when it isn't.

Comment 9

[sairuh (rarely reading bugmail)]

*** Bug 60616 has been marked as a duplicate of this bug. ***

Comment 10

[Bill Law]

Any feedback on my alternative fix?

Comment 11

[Simon Fraser [no longer active]]

It is selected now.

Comment 12

[sairuh (rarely reading bugmail)]

yep. vrfy fixed using branch comm bits on the 3 main platforms: 2001.06.07.0x.