602707 - [Form Assistant] Top of page shown when moving to password field on lastpass.com/mobile

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101007 Namoroka/4.0b7pre Fennec/4.0b2pre

Note: Bug based off of http://input.mozilla.com/en-US/opinion/528221

Steps to Reproduce:
1. Go to lastpass.com/mobile
2. Tap on "Email" field to open up the form assistant.
3. Tap on the down button on the form assistant bar

Actual Results:
The view goes to the top of the page.

Expected Results:
The view goes to the password field.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This is a zoom/pan fail. The focus _is_ in the password field.

Comment 2

[Matt Brubeck (:mbrubeck)]

I can't reproduce this.  Is it fixed?

Comment 3

[Aakash Desai [:aakashd]]

Yeah, this is still happening to me, but with an added step.

Steps to Reproduce:
1. Go to lastpass.com/mobile
2. Tap on "Email" field to open up the form assistant.
3. Tap on the down button on the form assistant bar
4. Type a character into the field

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Only an Android bug? This seems to be working fine on N900

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> Only an Android bug? This seems to be working fine on N900

Yes, I suspect it has to do with the window resize for the Android keyboard.

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: band-aid

This patch covers up the problem.  It's definitely not a real fix - you can sometimes still see the page flicker to the top briefly, but it immediately redraws at the correct location.

We still need a real fix for this.  (Maybe bug 595233 will fix it.)  But this change is worth taking in its own right.  It restores animation to formhelper scrolling,  and it fixes a related bug where the zoom can go outside the page boundaries and then snap back when it finishes.

Comment 7

[Matt Brubeck (:mbrubeck)]

Pushed the band-aid: http://hg.mozilla.org/mobile-browser/rev/676b16920e85

Filed bug 605119 to make sure we follow up with a real fix.

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Steps to Reproduce:
1. Go to lastpass.com/mobile
2. close hardware keyboard; go to landscape mode
3. Tap on "Email" field to open up the form assistant.
4. dismiss the vkb with the back button
5. Tap on the down button on the form assistant bar
6. Type a character into the field
7. dismiss the vkb with the back button

Note:
1. It happens on first landing on the page and these steps are followed.

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (android Linux armv7l; rv:2.0b7pre) Gecko/20101029 Firefox/4.0b8pre Fennec/4.0b2