The current code takes care of [%- -%] and [%+ +%], but not of [%~ ~%], probably because we weren't using ~ in the past. This makes it return some false alarm, such as in bug 581448. I have a patch almost ready.
Created attachment 481863 [details] [diff] [review] patch, v1 I moved the +/-/~ detection where we really parse [% ... %], because directive_ok() is used recursively with the |foo ? bar : baz| syntax, and in that case, it shouldn't treat +/-/~ as special.
Assignee: testing → LpSolit
Status: NEW → ASSIGNED
Attachment #481863 - Flags: review?(mkanat)
Comment on attachment 481863 [details] [diff] [review] patch, v1 Cool. :-)
Attachment #481863 - Flags: review?(mkanat) → review+
Committing to: bzr+ssh://email@example.com/bugzilla/trunk/ modified t/008filter.t Committed revision 7525. Committing to: bzr+ssh://firstname.lastname@example.org/bugzilla/4.0/ modified t/008filter.t Committed revision 7430.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.