If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

008filter.t doesn't catch [%~ ~%] correctly

RESOLVED FIXED in Bugzilla 4.0

Status

()

Bugzilla
Testing Suite
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

3.7.3
Bugzilla 4.0
Bug Flags:
approval +
approval4.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
The current code takes care of [%- -%] and [%+ +%], but not of [%~ ~%], probably because we weren't using ~ in the past. This makes it return some false alarm, such as in bug 581448. I have a patch almost ready.
(Assignee)

Comment 1

7 years ago
Created attachment 481863 [details] [diff] [review]
patch, v1

I moved the +/-/~ detection where we really parse [% ... %], because directive_ok() is used recursively with the |foo ? bar : baz| syntax, and in that case, it shouldn't treat +/-/~ as special.
Assignee: testing → LpSolit
Status: NEW → ASSIGNED
Attachment #481863 - Flags: review?(mkanat)

Comment 2

7 years ago
Comment on attachment 481863 [details] [diff] [review]
patch, v1

Cool. :-)
Attachment #481863 - Flags: review?(mkanat) → review+

Updated

7 years ago
Flags: approval4.0+
Flags: approval+
(Assignee)

Comment 3

7 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified t/008filter.t
Committed revision 7525.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified t/008filter.t
Committed revision 7430.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.