602875 - FBTYPE should default to BUSY

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Stefan Rijnhart]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.10) Gecko/20100915 Ubuntu/10.04 (lucid) Firefox/3.6.10
Build Identifier: 1.0b2

As per RFC5545 section 3.2.9, FBTYPE should default to BUSY when not specified in free/busy replies. When Lightning 1.0b2 displays free/busy information from servers which implement this behavior (such as Davical 0.9.9.3), the time periods are being marked as "No Information".



Reproducible: Always

Steps to Reproduce:
1.Connect to Davical 0.9.9.3
2.Invite attendees
3.Select attendee with free/busy information available on the server
Actual Results:  
Busy times are labeled as "No information"

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Sounds reasonable, we need to keep the "no information" status for server errors or no fitting freebusy provider though. Otherwise users might think that their meeting attendees are always busy.

Comment 2

[Frédéric PANES]

I experienced the same issue with both TB3.1 + Lightning 
1.0b2 under Windows XP and Ubuntu 10.04, here is a screenshot :

http://picasaweb.google.com/lh/photo/vcKVJYUM8t65gJne87vWvQ?feat=directlink

Comment 3

[Andrew McMillan]

The fix appears to be a trivial change, as follows (untested):

--- calDavCalendar.js.orig	2010-10-21 16:31:47.518560704 +1300
+++ calDavCalendar.js	2010-10-21 16:33:44.434253664 +1300
@@ -2027,7 +2027,7 @@
                             if (fbType) {
                                 fbType = fbTypeMap[fbType];
                             } else {
-                                fbType = calIFreeBusyInterval.UNKNOWN;
+                                fbType = calIFreeBusyInterval.BUSY;
                             }
                             let parts = fbProp.value.split("/");
                             let begin = cal.createDateTime(parts[0]);

Comment 4

[Felix Möller]

I just chatted with Andrew about this. 

It has been confirmed to work by users.

I had a look at the source and the patch is not applied yet.

See <http://hg.mozilla.org/comm-central/file/ef50f461a021/calendar/providers/caldav/calDavCalendar.js#l2120>

Comment 5

[Felix Möller]

Ok, I tested this myself now. With my own DAViCal Server and a patched Lightning. 

I think it is good to go.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/ca7ae9e7434a>
-> FIXED