Closed Bug 602893 Opened 9 years ago Closed 9 years ago

Put setting textboxes on separate row when in portrait

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We easily run out of space for a label and textbox on the same row in Fennec preferences. This patch puts the label and textbox on separate rows.

The patch adds some CSS classes to the setting XBL to make it easier to access from CSS.
Attachment #481859 - Flags: review?(mbrubeck)
Comment on attachment 481859 [details] [diff] [review]
patch

Looks nice!  Just one nit: if you add flex="1" to the xul:textbox element in the setting-string XBL, then you can get delete this slow CSS rule:

>+#editor-setting[type="string"] .setting-input > textbox {
>   -moz-box-flex: 1;
> }

This one is important because it will be tested against every <textbox> element, and it contains a descendant selector.
Attachment #481859 - Flags: review?(mbrubeck) → review+
(In reply to comment #1)
> Comment on attachment 481859 [details] [diff] [review]
> patch
> 
> Looks nice!  Just one nit: if you add flex="1" to the xul:textbox element in
> the setting-string XBL, then you can get delete this slow CSS rule:
> 
> >+#editor-setting[type="string"] .setting-input > textbox {
> >   -moz-box-flex: 1;
> > }
> 
> This one is important because it will be tested against every <textbox>
> element, and it contains a descendant selector.

I think we should file a new bug on reworking about:config and config.css
I think we should be using vertical aligned textboxes there too. And I found a weird bug with the editor.
pushed:
http://hg.mozilla.org/mobile-browser/rev/624d369d9020

filed bug 602945
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Can you provide some webpages to test this?
You need to log in before you can comment on or make changes to this bug.