KB links not working on click

VERIFIED FIXED in 2.3

Status

P1
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: rrosario, Assigned: paulc)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
In screencast.js, there is a click handler for all '.video a'. It turns out that Modernizr adds 'video' class to the document root (<html />) when <video /> is supported, and '.video a' becomes all links on the page :-O.

We probably need a more specific classname to avoid naming collisions.
(Assignee)

Comment 1

8 years ago
I caused it. I'll fix it. Thanks Ricky!
Assignee: nobody → paulc
(Assignee)

Comment 2

8 years ago
I'll take the opportunity to also fix the slide event when there are multiple videos on the page.
(Assignee)

Comment 3

8 years ago
http://github.com/jsocol/kitsune/commit/51a1a1fa3650c5ea42f06d88c5ac8ddad4bda03b
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Is this possible to verify prior to the implementation of the media gallery? If so please add steps
(Assignee)

Comment 5

8 years ago
In the e.g. page history view, you couldn't click on any of the links that linked to the wiki page itself (not even the breadcrumbs). There was some javascript code catching the click event and preventing the default behavior.
Verified all links on history page, including breadcrumbs, are working correctly
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.