ASSERTION: null node passed to nsHTMLEditUtils::IsMozBR and nsEditor::Tag when entering text in input controls focused by code or tabbing into them

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
Editor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({assertion, regression})

Trunk
mozilla2.0b7
x86
Mac OS X
assertion, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

STR:

1. Load the test case.
2. Type something into the field.

###!!! ASSERTION: null node passed to nsHTMLEditUtils::IsMozBR: 'node', file /Users/ehsanakhgari/moz/mozilla-central/editor/libeditor/text/nsTextEditUtils.cpp, line 74
###!!! ASSERTION: null node passed to nsEditor::Tag(): 'aNode', file /Users/ehsanakhgari/moz/mozilla-central/editor/libeditor/base/nsEditor.cpp, line 3731
These assertions are benign in the sense that nothing bad happens at runtime (IsMozBR just returns false), but we should still fix them.
(Assignee)

Comment 1

8 years ago
Created attachment 481893 [details] [diff] [review]
Patch (v1)

Actually check possibleMozBRNode before passing it to IsMozBR.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #481893 - Flags: review?(roc)
Attachment #481893 - Flags: approval2.0?
Attachment #481893 - Flags: review?(roc)
Attachment #481893 - Flags: review+
Attachment #481893 - Flags: approval2.0?
Attachment #481893 - Flags: approval2.0+
(Assignee)

Updated

8 years ago
Whiteboard: [needs landing]
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/464e830c883f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.