603071 - [D3D10] crash [@ mozilla::layers::PlanarYCbCrImageD3D10::AllocateTextures() ]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Scoobidiver (away)]

Build: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101008 Firefox/4.0b8pre

This is a new crash signature. Crashes first appeared in b8pre/20101007 build.
It is #5 top crasher in b8pre/20101008 build.

Signature	mozilla::layers::PlanarYCbCrImageD3D10::AllocateTextures()
UUID	fb529673-9f3a-4c1c-9f26-2c6292101009
Time 	2010-10-09 03:43:52.167111
Uptime	3097
Last Crash	4460 seconds (1.2 hours) before submission
Install Age	77952 seconds (21.7 hours) since version was first installed.
Product	Firefox
Version	4.0b8pre
Build ID	20101008041525
Branch	2.0
OS	Windows NT
OS Version	6.1.7600
CPU	x86
CPU Info	GenuineIntel family 6 model 23 stepping 6
Crash Reason	EXCEPTION_ACCESS_VIOLATION_READ
Crash Address	0xc35e7f
App Notes 	AdapterVendorID: 10de, AdapterDeviceID: 064c

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	mozilla::layers::PlanarYCbCrImageD3D10::AllocateTextures 	gfx/layers/d3d10/ImageLayerD3D10.cpp:322
1 	xul.dll 	mozilla::layers::PlanarYCbCrImageD3D10::SetData 	gfx/layers/d3d10/ImageLayerD3D10.cpp:288

The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dee1e01fd8ed&tochange=5bb4f093a50b

More reports at:
http://crash-stats.mozilla.com/report/list?product=Firefox&query_search=signature&query_type=exact&query=&range_value=4&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=mozilla%3A%3Alayers%3A%3APlanarYCbCrImageD3D10%3A%3AAllocateTextures%28%29

Comment 1

[JK]

Happens with lots of HTML5/WebM videos open.

Comment 2

[Bas Schouten (:bas.schouten)]

Top 5? I wouldn't have expected that many people to switch D3D10 layers on.

Comment 3

[Scoobidiver (away)]

> Top 5? I wouldn't have expected that many people to switch D3D10 layers on.
According to the crash stats, there are four different users.

Comment 4

[JK]

Doesn't seem to happen anymore, at least with HTML5 Youtube.

Comment 5

[Bas Schouten (:bas.schouten)]

How weird, I didn't do anything!

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: Part 1: Fix destruction safety inside LayerManagerD3D10

I'm taking this opportunity to fix ownership, there's a small bug here where Destroy wasn't implemented to clear all references from its layer tree like it does for other layer manager. This should fix this.

Comment 7

[Bas Schouten (:bas.schouten)]

Attachment: Part 2: Fix thread safety for PlanarYCbCrImageD3D10

PlanarYCbCrImageD3D10 should hold a reference to the D3D10 device since it needs to have this device around when SetData is called. Not storing the manager but rather the device is the best solution here.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why is PlanarYCbCrImageD3D10 calling AllocateTextures in SetData? Can't you defer the AllocateTextures until we paint? That's what we do in ImageLayerOGL, and it means AllocateTextures only happens on the main thread.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(I can see how calling AllocateTextures off the main thread might let you avoid a copy, but you're not doing that.)

Comment 10

[Bas Schouten (:bas.schouten)]

(In reply to comment #8)
> Why is PlanarYCbCrImageD3D10 calling AllocateTextures in SetData? Can't you
> defer the AllocateTextures until we paint? That's what we do in ImageLayerOGL,
> and it means AllocateTextures only happens on the main thread.

Texture allocation is fairly CPU intensive, also these function may create an additional internal copy, this copy is now executed on a separate thread. I believe these 3 calls constitute a fairly significant amount of work, so I personally think it's worth it to do it on the decoding thread.

Eventually as you say, it might also help us avoid the copy.

Comment 11

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/48e881871600

Comment 12

[Bas Schouten (:bas.schouten)]

http://hg.mozilla.org/mozilla-central/rev/7e6aa107b815