603076 - Windows SDK 7.1 isn't handled properly in guess-msvc.bat

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Gabriele Best [:Gabri]]

Attachment: Patch#0

Bug 579159 added SDK7.1 to guess-msvc.bat but there's a bug on its regkey value delimiter (line 134) which uses 2 spaces instead of 1 tab and 1 space.

I think we should resolve this bug using 3 approaches:
1. Add the correct delimiter to the SDK7.1 handle string (Patch#0)
2. Remove all the delimiters because we use the default one (1 tab + 1 space) (Patch#1)
3. Change all the delimiters to a more readable form such as "delims=<TAB> " which works properly (Patch#2)

I've also added to each patch the reset of SDKDIR var, so guess-msvc.bat is able to update that var if we install a new SDK package (It fixes also the "Windows SDK version: 0.0" bug).

Comment 1

[Gabriele Best [:Gabri]]

Attachment: Patch#1

Comment 2

[Gabriele Best [:Gabri]]

Attachment: Patch#2

Comment 3

[(not currently active) Ted Mielczarek]

Oh, I didn't notice that these were three *alternatives*. Honestly, I don't care. r=me to land whichever one of these you prefer.

Comment 4

[Gabriele Best [:Gabri]]

Attachment: Patch v1.1

* Removed all the "delims" attributes from all the REG QUERY instructions;
* Removed all the "usebackq" attributes from all the REG QUERY instructions using a cleaner istruction coding (('REG QUERY...') instead of: (`REG QUERY...`));

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-build/rev/49de3752d798