603125 - [Step 6] Fabricate the Select a Review Process page

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Current URL: none, this is a new page
New URL: https://addons.mozilla.org/en-US/developers/addon/submit/6
Mockup: http://people.mozilla.com/~chowse/drop/amo/devtools/v3/addon_submission/06_review_process.png

This is a new page.  The new developer tools will let users decide to do a full review or a preliminary review.  The effects for an author are detailed here[1], but the effects for this particular page are simply a flag on the backend that says which choice they made.  

CCing fligtar for copy and to say where the "Learn more..." links go.

[1] https://docs.google.com/Doc?docid=0Acwo2Bn17-PrZGZudHRobnJfNzdka3Q2bTdkYw&hl=en

Comment 1

[Justin Scott [:fligtar]]

All add-ons hosted in our gallery must be reviewed by an editor before they appear in categories or search results. While waiting for review, your add-on can still be accessed through its direct URL. Please choose the review process below that best fits your add-on.

Full Review
A complete review of your add-on's source and functionality. [Learn more]
* Appropriate for polished add-ons
* Review should take place within 10 days
* Review of subsequent versions within 5 days
* Warning-free installation and no feature limitations

Preliminary Review
A faster review of your add-on's source for any major problems. [Learn more]
* Appropriate for experimental add-ons
* Review should take place within 3 days
* Some feature limitations
* Binary and obfuscated add-ons ineligible
* Cannot request Full Review for 10 days

---

The Learn more links should go to https://addons.mozilla.org/en-US/developers/docs/policies/reviews#selection

(I have a bunch of copy I'll need to add to that page but not until we're about to go live as it would be confusing now.)

Comment 2

[Wil Clouser [:clouserw]]

Attachment: statuses

It looks like we need to make 2 new STATUS_* variables (apps/amo/__init__.py) for our new preliminary statues.  I'm attaching a whiteboard of our current statuses (on the right) and adding the new ones (on the left).

The full review can set the add-on status to STATUS_NOMINATED.  The preliminary one should set a new STATUS_PRELIM_NOMINATED.  The other status isn't a part of this page, but we should add it.  Let's call it STATUS_PRELIM_AND_NOMINATED.

You can see my awesome idea in the bottom left to have only 3 statuses and making 4 flags but it got frowny faced.

Comment 3

[Kumar McMillan [:kumar]]

Note that in bug 607726 I created the finished page which tells the developer which review queue his/her add-on has been submitted to.

I laid down the framework for it as a new type of review not a status.  See https://github.com/jbalogh/zamboni/commit/260269efd7e7b9eceee1cddc394bafb4948f2089

But it can change :)  Just let me know.  Otherwise, you could re-use that model.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/08122f4