603210 - Fix test: browser_webconsole_bug_580030_errors_after_page_reload.js

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

This test asserts and/or fails too often - needs a refactor. Have had to remove it from the webconsole suite.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed test fix

Proposed test fix. Changes:

- the DOMContentLoaded event is fired before load, and we are trying to reload the page before it completes the first load. Changed the code to use only the load event.

- use executeSoon() in the onLoad event handler because we do not want to ask for reloading while the browser still executes the onload event handlers. We push the reload() call a bit later this way.

- we use a synthetic MouseEvent that is not wrapped by xpcom, to workaround a bug in Gecko that prevents the logging of exceptions thrown in event handlers executed by synthetic events.

- removed the output error line check, because that depends on UI localization and was unneeded. I don't know when this check was added. Afaik, it wasn't in the initial test I submitted.

The test now runs fine in opt and debug builds.

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 482822 [details] [diff] [review]
proposed test fix

Thanks David for the feedback+! Asking for review now.

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 482822 [details] [diff] [review]
proposed test fix

Canceling review request - this only a test fix, and it seems reviews are not needed for such changes.

Comment 4

[Mihai Sucan [:msucan]]

Adding checkin-needed, given it's only a test change.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: [checked-in] rebased patch (fix for compartments)

Fix for compartments landing.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 484019 [details] [diff] [review]
[checked-in] rebased patch (fix for compartments)

http://hg.mozilla.org/mozilla-central/rev/e695ac53ec47