Fix test: browser_webconsole_bug_580030_errors_after_page_reload.js

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
4 months ago

People

(Reporter: ddahl, Assigned: msucan)

Tracking

Trunk
x86
All
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patchclean:1018])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
This test asserts and/or fails too often - needs a refactor. Have had to remove it from the webconsole suite.
(Reporter)

Updated

8 years ago
Depends on: 581069

Updated

8 years ago
Assignee: nobody → mihai.sucan
Blocks: 594225
(Assignee)

Comment 1

8 years ago
Created attachment 482822 [details] [diff] [review]
proposed test fix

Proposed test fix. Changes:

- the DOMContentLoaded event is fired before load, and we are trying to reload the page before it completes the first load. Changed the code to use only the load event.

- use executeSoon() in the onLoad event handler because we do not want to ask for reloading while the browser still executes the onload event handlers. We push the reload() call a bit later this way.

- we use a synthetic MouseEvent that is not wrapped by xpcom, to workaround a bug in Gecko that prevents the logging of exceptions thrown in event handlers executed by synthetic events.

- removed the output error line check, because that depends on UI localization and was unneeded. I don't know when this check was added. Afaik, it wasn't in the initial test I submitted.

The test now runs fine in opt and debug builds.
Attachment #482822 - Flags: feedback?(ddahl)
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1013]
(Reporter)

Updated

8 years ago
Attachment #482822 - Flags: feedback?(ddahl) → feedback+
(Assignee)

Comment 2

8 years ago
Comment on attachment 482822 [details] [diff] [review]
proposed test fix

Thanks David for the feedback+! Asking for review now.
Attachment #482822 - Flags: review?(dietrich)
(Assignee)

Comment 3

8 years ago
Comment on attachment 482822 [details] [diff] [review]
proposed test fix

Canceling review request - this only a test fix, and it seems reviews are not needed for such changes.
Attachment #482822 - Flags: review?(dietrich)
(Assignee)

Comment 4

8 years ago
Adding checkin-needed, given it's only a test change.
Keywords: checkin-needed
(Assignee)

Comment 5

8 years ago
Created attachment 484019 [details] [diff] [review]
[checked-in] rebased patch (fix for compartments)

Fix for compartments landing.
Attachment #482822 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Whiteboard: [patchclean:1013] → [patchclean:1018]
Comment on attachment 484019 [details] [diff] [review]
[checked-in] rebased patch (fix for compartments)

http://hg.mozilla.org/mozilla-central/rev/e695ac53ec47
Attachment #484019 - Attachment description: rebased patch (fix for compartments) → [checked-in] rebased patch (fix for compartments)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.