Closed
Bug 603251
Opened 14 years ago
Closed 14 years ago
Fix test: browser_webconsole_basic_net_logging.js
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ddahl, Assigned: msucan)
References
Details
(Whiteboard: [patchclean:1016])
Attachments
(1 file)
3.13 KB,
patch
|
ddahl
:
feedback+
|
Details | Diff | Splinter Review |
Fails on linux debug builds only *on tinderbox*. Still cannot get it to fail locally.
Disabled 2 checks.
Assignee | ||
Comment 1•14 years ago
|
||
While working on some other patch I bumped into this mochitest file and I saw the TODO. The fix looked quite easy for me to do, and here's the result.
The problem was that the test file used the DOMContentLoaded event which fires before images and scripts from the page are loaded. Besides that, it also had some errors in the way it tried to access the output content to check the presence of the logged requests.
I should note that by enabling the two tests, it did fail for me badly in both debug and opt builds, on Linux.
With this patch, the test runs fine in debug and opt builds.
Assignee | ||
Updated•14 years ago
|
Whiteboard: [patchclean:1016]
Updated•14 years ago
|
Blocks: devtools4b8
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 483712 [details] [diff] [review]
[checked-in] proposed fix
I trust you also tested this after the xray wrapper landed. Looks like my brain had turned to mush when working on this, using the wrong eventHandler call.
Attachment #483712 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Comment on attachment 483712 [details] [diff] [review]
> proposed fix
>
> I trust you also tested this after the xray wrapper landed. Looks like my brain
> had turned to mush when working on this, using the wrong eventHandler call.
Thanks for the feedback+!
I retested this patch today. Still runs fine, no problems with compartments landing.
Keywords: checkin-needed
Comment 4•14 years ago
|
||
Comment on attachment 483712 [details] [diff] [review]
[checked-in] proposed fix
http://hg.mozilla.org/mozilla-central/rev/b3e685377d7b
Attachment #483712 -
Attachment description: proposed fix → [checked-in] proposed fix
Updated•14 years ago
|
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•