Closed Bug 603311 Opened 9 years ago Closed 9 years ago

HashMgr::load_tables leaks dict when decode_flags fails

Categories

(Core :: Spelling checker, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- ?

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak, Whiteboard: [fixed-in-hunspell-1.2.13])

Attachments

(1 file)

406 int HashMgr::load_tables(const char * tpath, const char * key)

416   FileMgr * dict = new FileMgr(tpath, key);

492     if (ap) {
494       if (aliasf) {
501       } else {
502         al = decode_flags(&flags, ap + 1, dict);
503         if (al == -1) {
504             HUNSPELL_WARNING(stderr, "Can't allocate memory.\n");
505             return 6;
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #482397 - Flags: review?(ryanvm)
Attachment #482397 - Flags: review?(ryanvm) → review?(caolanm)
Comment on attachment 482397 [details] [diff] [review]
patch

yes, looks good, committed to hunspell cvs
Attachment #482397 - Flags: review?(caolanm) → review+
Whiteboard: [fixed-in-hunspell-1.2.13]
Attachment #482397 - Flags: approval2.0?
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status1.9.2: --- → ?
Resolution: --- → FIXED
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
You need to log in before you can comment on or make changes to this bug.