603314 - Unprivileged users cannot create bugs any more

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Marc Schumann [:Wurblzap]]

Attachment: Patch

+++ This bug was initially created as a clone of Bug 565790 +++

Unprivileged users get a "Can't call method "name" on an undefined value at enter_bug.cgi line 561." message instead of the bug entry form, after having selected classification and product.

Happens on branch and trunk.

The error is in a part of code touched by bug 565790. I'm not sure whether this is a regression of it, though, because the bug was intended to fix another error in the same situation.

Comment 1

[Frédéric Buclin]

Comment on attachment 482231 [details] [diff] [review]
Patch

>-    @statuses = ($unconfirmed || $statuses[0]);
>+    @statuses = ($unconfirmed ? $unconfirmed : $statuses[0]);

This change doesn't make sense to me. The behavior is exactly the same.

Comment 2

[Marc Schumann [:Wurblzap]]

Yeah, that's what I thought, too. But try and see the difference :)

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> Yeah, that's what I thought, too. But try and see the difference :)

Indeed. I wonder if this has something to do with the fact that we are updating @statuses with its own elements.

Comment 4

[Frédéric Buclin]

The error log shows:

enter_bug.cgi: semi-panic: attempt to dup freed string


And I found that this means:

"The internal newSVsv() routine was called to duplicate a scalar that had previously been marked as free."

So my assumption was correct.

Comment 5

[Frédéric Buclin]

Comment on attachment 482231 [details] [diff] [review]
Patch

OK, let's go with this fix. People in #perl are as confused as I am. Perl 5.14 no longer throws this error, but still frees @a before we have the time to catch $a[0]. So this fix is needed for Perl 5.14 too. r=LpSolit to work around this Perl bug.

Comment 6

[Marc Schumann [:Wurblzap]]

Trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified enter_bug.cgi
Committed revision 7526.

Branch:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified enter_bug.cgi
Committed revision 7431.

Thanks for the review.

Comment 7

[Max Kanat-Alexander]

It'd be nice if somebody could put a comment above that line, as a post-checkin fix. Otherwise I'm pretty certain that someday somebody will look at it and say "That doesn't make sense" and remove it.

Comment 8

[Marc Schumann [:Wurblzap]]

Yeah, can do. Frédéric, did you file a Perl bug I can refer to?

Comment 9

[Frédéric Buclin]

(In reply to comment #8)
> Yeah, can do. Frédéric, did you file a Perl bug I can refer to?

I didn't, because Perl 5.14 no longer throws an error. You can simply refer to this bug.

Comment 10

[Marc Schumann [:Wurblzap]]

Trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified enter_bug.cgi
Committed revision 7530.

Branch:
Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified enter_bug.cgi
Committed revision 7432.