603326 - CPPpragma mishandles/leaks allTokens

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[timeless]

566 static int CPPpragma(yystypepp * yylvalpp)
567 {

alloc:
584         allTokens = (char**)malloc(sizeof(char*) * maxTokenCount);      

586         while (token != '\n') {

mishandle realloc (you need to use a temporary and compare against null to decide if it succeeded):
589                         allTokens = (char**)realloc((char**)allTokens, sizeof(char*) * maxTokenCount);
590                 }


591                 switch (token) {
592                 case CPP_IDENTIFIER:
597                 case CPP_INTCONSTANT:
602                 case CPP_FLOATCONSTANT:
606                         break;
607                 case -1:
608             // EOF
609             CPPShInfoLogMsg("#pragma directive must end with a newline");                       

allTokens is leaked here:
610                         return token;

Comment 1

[timeless]

Attachment: patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Needs to be filed at http://code.google.com/p/angleproject/ -- please file further ANGLE bugs there.

Comment 3

[Matt Woodrow (:mattwoodrow)]

This has been marked as accepted on the angle bug tracker, we don't need to patch this locally.