Closed Bug 603332 Opened 9 years ago Closed 8 years ago

Missing preferences that cause support problems in about:support (Troubleshooting Information)

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 10
Tracking Status
blocking2.0 --- .x+

People

(Reporter: zzxc, Assigned: Tobbi)

Details

Attachments

(1 file, 2 obsolete files)

The about:support troubleshooting information doesn't include the middle mouse button preferences, which has been a problem for users troubleshooting why autoscrolling or mousewheel scrolling/zooming are not working.

The preferences that should be added are:
mousewheel.* (currently whitelisted incorrectly as browser.mousewheel.*)
general.autoScroll
Other preferences that are missing:
permissions.default.image (controls when images are displayed on web sites)
browser.display.* (controls whether colors and background images are used)
services.sync.* (controls whether preferences are synced via Firefox Sync)
blocking2.0: --- → ?
Summary: Middle mouse button preferences not listed on about:support → Missing preferences that cause support problems in about:support (Troubleshooting Information)
Nice to have, and AIUI can also be added in a stability and support release. Not a blocker for Firefox 4.
blocking2.0: ? → .x
Attached patch patch (obsolete) — Splinter Review
This patch changes the order of the preferences so that it's alphabetical,
changes browser.mousewheel to mousewheel and adds all the proposed preferences to the whitelist
Assignee: nobody → tobbi.bugs
Status: NEW → ASSIGNED
Attachment #537639 - Flags: review?
Attachment #537639 - Flags: review? → review?(gavin.sharp)
Attachment #537639 - Flags: review?(gavin.sharp)
Attached patch patch v2 (obsolete) — Splinter Review
Attachment #537639 - Attachment is obsolete: true
Comment on attachment 537643 [details] [diff] [review]
patch v2

Review of attachment 537643 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #537643 - Flags: review?(gavin.sharp)
Comment on attachment 537643 [details] [diff] [review]
patch v2

services.sync.* includes tons of private information (lastSyncTime, "GUID", clusterURL, etc.), so we shouldn't include it here. If there are things there that need to be specifically included we can do that. The other changes look fine.
Attachment #537643 - Flags: review?(gavin.sharp) → review-
Attached patch patch v3Splinter Review
v3, excluding services.sync. 

I suppose we can decide on what sync preferences to include later. But for now, this should be everything.
Attachment #537643 - Attachment is obsolete: true
Attachment #537647 - Flags: review?(gavin.sharp)
Attachment #537647 - Flags: review?(gavin.sharp) → review+
Can someone check this in, please?
Keywords: checkin-needed
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Made the comment 9 changes in the end, just so this manages to make Firefox 10, for SUMO's sake.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a15e40c515eb
Keywords: checkin-needed
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/a15e40c515eb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.