Closed Bug 603388 Opened 14 years ago Closed 14 years ago

Merge fx-sync to mozilla-central

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: philikon, Assigned: philikon)

References

Details

      No description provided.
has a disable logging patch that is very good for mobile.  we want to for our upcoming beta.
Depends on: 597404, 603502
Depends on: 562431
Together with this merge we need to land attachment.cgi 482277 from bug 562431 (fixes to the m-c build system)
(In reply to comment #2)
> Together with this merge we need to land attachment.cgi 482277 from bug 562431
> (fixes to the m-c build system)

Actually we need v2 (or whatever is the latest version) of that patch to make sure tests are executed.
Assignee: nobody → philipp
http://hg.mozilla.org/mozilla-central/rev/7b6f71ee1ab4
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 570619
Sync is not working after landing of these bugs.

I tried on a new profile, with a newly created Sync account.

The Sync extension is working fine.
(In reply to comment #5)
> Sync is not working after landing of these bugs.

Please define "not working". Perhaps the best thing would be to file a new bug and attach the output of about:sync-log (though you now need to explicitly turn on logging by setting the services.sync.log.appender.debugLog preference to true).

Also, what are you using? A custom build? These changes just landed this morning, so they're not in a nightly yet. If it's a custom build, could it be you're running into the problem caused by bug 586867 (which was backed out later)?

> I tried on a new profile, with a newly created Sync account.
> 
> The Sync extension is working fine.

Which version of the Sync add-on?
1.5

That version contains this bug's changes? :S
Ah, sorry for double posting.

It doesn't sync anything.

It doesn't even creates the log files in my profile folder/weave. 

I'm using an hourly build. (00e90d9720c8) It should contain the recent sync merge.
(In reply to comment #7)
> 1.5
> 
> That version contains this bug's changes? :S

No.

(In reply to comment #8)
> It doesn't even creates the log files in my profile folder/weave. 

As I've said, you now need to explicitly turn on logging, but I told you the wrong pref. The right pref is services.sync.log.appender.debugLog.enabled (you need to create it as a Boolean and set it to true).

Anyway, I can't reproduce this. So please if you continue to have problems file a *new* bug and attach your sync log. This a resolved meta bug, not the best place to discuss problems ;)
Filed Bug 604784 . I attached the crashreports i got.
You need to log in before you can comment on or make changes to this bug.