Open
Bug 603392
Opened 14 years ago
Updated 14 years ago
Rename tabmail.closeTabs to something more sensible
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(Not tracked)
NEW
People
(Reporter: rain1, Unassigned)
Details
Attachments
(1 file)
1.70 KB,
patch
|
mnyromyr
:
review-
|
Details | Diff | Splinter Review |
This patch fixes SeaMonkey, in case it makes sense for you too.
+++ This bug was initially created as a clone of Bug #603391 +++
Per <https://mail.mozilla.org/pipermail/tb-planning/2010-October/000527.html>. I don't care about the name too much (anything's better than closeTabs), but _teardown is short, sweet and descriptive.
Attachment #482266 -
Flags: review?(mnyromyr)
Comment 1•14 years ago
|
||
Comment on attachment 482266 [details] [diff] [review]
patch
> This patch fixes SeaMonkey, in case it makes sense for you too.
> +++ This bug was initially created as a clone of Bug #603391 +++
Thanks for caring!
> Per <https://mail.mozilla.org/pipermail/tb-planning/2010-October/000527.html>.
> I don't care about the name too much (anything's better than closeTabs), but
> _teardown is short, sweet and descriptive.
Asuth's arguments there don't quite hold for SeaMonkey - our leftmost tab is in no way special (and will be even less in future), you can close it, if others remain. Furthermore, the name "_teardown" is no better...
I might reconsider this if addons start using it (heavily) - which they shouldn't anyhow -, but this is r- for the time being.
Attachment #482266 -
Flags: review?(mnyromyr) → review-
You need to log in
before you can comment on or make changes to this bug.
Description
•