Blacklist out of process Java plugins on Windows

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(blocking2.0 beta8+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Due to various issues with ui created by 3rd party java processes it's been suggested that we should just disable OOPP for java.
(Assignee)

Updated

7 years ago
blocking2.0: --- → ?
That means Java crashes will take the browser down, right?  Is that a smaller problem?

Comment 2

7 years ago
Not exactly: the java plugin actually runs its own separate Java process, so the crashes we might experience are only the ones in the plugin, not in all of java. It's a smaller surface area, and we're less exposed to instability in java itself.
(Assignee)

Comment 3

7 years ago
I seriously doubt the java footprint in general is very large. I rarely run into applets anymore.
(In reply to comment #2)
> Not exactly: the java plugin actually runs its own separate Java process, so
> the crashes we might experience are only the ones in the plugin, not in all of
> java.

Maybe a dumb question, but does the Java plugin actually deal gracefully when its subprocess crashes?

Comment 5

7 years ago
I don't know, can you kill some java and find out?
(In reply to comment #3)
> I seriously doubt the java footprint in general is very large. I rarely run
> into applets anymore.

AFAIK there are quite a few high-profile games online that use Java. Also, dell uses Java as does NVidia (just to name a few high-profile sites) as a replacement for activeX.

Updated

7 years ago
Assignee: nobody → jmathies
blocking2.0: ? → beta8+
(Assignee)

Comment 7

7 years ago
Created attachment 483263 [details] [diff] [review]
patch

This only blacklists the latest. Apparently there are multiple version of this file, all with different dll names.

http://processlist.com/info/jpinsp.html

I wonder how many of these we should be adding. This patch takes care of updated installs.
Attachment #483263 - Flags: review?(benjamin)
(Assignee)

Updated

7 years ago
Attachment #483263 - Flags: review?(benjamin)
(Assignee)

Comment 8

7 years ago
Created attachment 483294 [details] [diff] [review]
patch
Attachment #483263 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Attachment #483294 - Flags: review?(benjamin)

Updated

7 years ago
Attachment #483294 - Flags: review?(joshmoz)
Attachment #483294 - Flags: review?(benjamin)
Attachment #483294 - Flags: review+

Updated

7 years ago
Summary: Blacklist out of process Java plugins → Blacklist out of process Java plugins on Windows

Comment 9

7 years ago
Comment on attachment 483294 [details] [diff] [review]
patch

Looks OK, but we already assume that 'aPluginTag' is non-NULL in this function, before the code you're adding. I don't know if that is by design or not, but in any case lets do one NULL check at the top of the function and then don't check it again. This will mean removing other NULL checks in the function as well, not just the one you're adding.
Attachment #483294 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 10

7 years ago
Created attachment 483491 [details] [diff] [review]
updated patch
(Assignee)

Comment 11

7 years ago
I guess to match the formatting here I should also add parenthesis around that. I'll update that in the patch I land.
(Assignee)

Comment 12

7 years ago
http://hg.mozilla.org/mozilla-central/rev/6bef1538745f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.