Closed Bug 603423 Opened 10 years ago Closed 9 years ago
Html5Stream Parser::On Start Request shouldn't propagate errors from Get Unicode Decoder
This is exposed by my patch for bug 601429. If GetUnicodeDecoder fails, nsHtml5StreamParser::OnStartRequest passes the error code back to its caller. Later SetupDecodingAndWriteSniffingBufferAndCurrentSegment calls GetUnicoderDecoder again with a fallback charset, but because of the earlier failure the output buffers aren't set up, so Convert never gets called and the page ends up blank.
Assignee: nobody → smontagu
Attachment #482307 - Flags: review?(hsivonen)
Comment on attachment 482307 [details] [diff] [review] Patch r=hsivonen if you also on failure set mCharsetSource to kCharsetFromWeakDocTypeDefault (or whatever you deem to be appropriate as long as it's < kCharsetFromMetaPrescan).
Attachment #482307 - Flags: review?(hsivonen) → review+
Carrying over r=hsivonen. Now that bug 601429 is checked in, we ought to take this to fix the regression that it exposed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.