Closed
Bug 603533
Opened 14 years ago
Closed 14 years ago
valgrind errors during mochitest-other
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: sayrer, Assigned: mrbkap)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(2 files)
12.73 KB,
text/plain
|
Details | |
6.16 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
I've caught some of these.
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → beta7+
Reporter | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
if (IsOuterWindow() && !aIgnoreModalDialog) { <==== here nsGlobalWindow* inner = GetCurrentInnerWindowInternal(); nsCOMPtr<nsIDOMModalContentWindow>
Reporter | ||
Updated•14 years ago
|
blocking2.0: beta7+ → ---
OS: Linux → All
Reporter | ||
Comment 3•14 years ago
|
||
==27397== Invalid read of size 8 ==27397== at 0x1E97073B: ??? ==27397== by 0x62804C9: js::mjit::JaegerShot(JSContext*) (MethodJIT.cpp:742) I filed Bug 603534 on a similar problem that can reliably be reproduced by loading GMail.
Reporter | ||
Comment 4•14 years ago
|
||
I can still reproduce the nsGlobalWindow::CleanUp bug with --smc-check=all enabled.
Comment 5•14 years ago
|
||
Yes, the CleanUp looks very real (see #2). mrbkap?
Assignee | ||
Comment 6•14 years ago
|
||
This is fallout from the fact that we now call functions on the inner window instead of the outer. We have a strong reference in the outer to the inner (mInnerWindowHolder) but not the other way around. So, we need to explicitly hold a strong reference to the outer when we forward to it, otherwise we risk the outer dying too early.
Updated•14 years ago
|
Attachment #482590 -
Flags: review?(jst) → review+
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/4d4f6ecca0e0
Whiteboard: fixed-in-tracemonkey
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → beta7+
Reporter | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4d4f6ecca0e0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•