603562 - Socorro homepage doesn't validate

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://html5.validator.nu/?doc=http%3A%2F%2Fcrash-stats.stage.mozilla.com%2F doesn't validate

Comment 1

[Nigel Babu [:nigelb]]

Attachment: Validate the home page

Attached patch gets the home page to validate. Had to make a small mess with select boxes on top bar.

Comment 2

[Lonnen :lonnen]

Comment on attachment 547768 [details] [diff] [review]
Validate the home page

This is pretty good and validates fine, but if we must have the label's in the optgroup tags they should have some kind of content. The labels can be obvious, but I'd like to have something there. Ping me in channel if you need help with what to fill them in with. Fix those and this is good to go.

Comment 3

[Lonnen :lonnen]

Comment on attachment 547768 [details] [diff] [review]
Validate the home page

Review of attachment 547768 [details] [diff] [review]:
-----------------------------------------------------------------

After reading the HTML standard I've changed my mind and I'm happy with empty labels.

Comment 4

[Lonnen :lonnen]

Checked in for Nigel as r3300 (http://code.google.com/p/socorro/source/detail?r=3300)

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: http://html5.validator.nu/?doc=http%3A%2F%2Fcrash-stats-dev.allizom.org

Thanks, Nigel!