input.list shouldn't return the element associated with the id if it's not a datalist element

RESOLVED FIXED in mozilla2.0b7

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({dev-doc-complete})

Trunk
mozilla2.0b7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
Fix attached.
Tests are in bug 595070.
Attachment #482506 - Flags: review?(jonas)
Assignee

Updated

9 years ago
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Assignee

Updated

9 years ago
Attachment #482506 - Flags: approval2.0?
Assignee

Updated

9 years ago
Blocks: 556007
Assignee

Updated

9 years ago
Blocks: 595070
Comment on attachment 482506 [details] [diff] [review]
Patch v1

Why not use the version of IsHTML() that takes an nsIAtom, like so:

  if (elem && elem->IsHTML(nsGkAtoms::datalist)) {

?
Assignee

Comment 2

9 years ago
Posted patch Patch v1.1Splinter Review
Because I completely forgot about it...

Could you review it? :)
Attachment #482506 - Attachment is obsolete: true
Attachment #482526 - Flags: review?(bzbarsky)
Attachment #482526 - Flags: approval2.0?
Attachment #482506 - Flags: review?(jonas)
Attachment #482506 - Flags: approval2.0?
Comment on attachment 482526 [details] [diff] [review]
Patch v1.1

Sure thing.
Attachment #482526 - Flags: review?(bzbarsky)
Attachment #482526 - Flags: review+
Attachment #482526 - Flags: approval2.0?
Attachment #482526 - Flags: approval2.0+
Assignee

Comment 4

9 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/3a82ec14162a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.