603588 - Can't edit the input fields for bookmark

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Ioana Chiorean]

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; en-US; rv:2.0b7pre)
Gecko/20101011 Firefox/4.0b7pre Fennec/4.0b2pre 

Device Motorola Droid 2

Steps to reproduce:
1. Open Fennec
2. Assure you have some bookmarks 
3. Tap the awesome bar, go to bookmarks
4. long tap on a bookmark -> context menu appears -> select edit
5. choose one of the 3 input fields, tap it and try to enter some letters 

Expected result:
- the test enter should be present in the text input fields

Actual result:
- the focus moves in the url bar and yo are not able to modify the bookmark edit fields.

Note :
- behavior present also on Maemo
- tapping back brings you to the webpage not the bookmarks

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This is a recent regression. My builds from Oct 10 work fine. If I had to guess, I'd pick bug 596614.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch prevent the automatic editing of the urlbar to take effect if the selection is manual.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 483130 [details] [diff] [review]
Patch

Components.interfaces.nsIFocusManager.FLAG_BYMOUSE -> Ci.nsIFocusManager.FLAG_BYMOUSE

And why does this work, but xxx.focus() does not? Tell me why this patch makes things work.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

The setFocus calls was too hacky and to disturbing, this patch use a completely different approach and move some code from browserUI.js to the urlbar-edit binding

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/6d84cb3083a7

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101015 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101015 Namoroka/4.0b8pre Fennec/4.0b2pre