Closed Bug 603588 Opened 9 years ago Closed 9 years ago

Can't edit the input fields for bookmark

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

defect
Not set

Tracking

(fennec2.0b2+)

VERIFIED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: ioana.chiorean, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; en-US; rv:2.0b7pre)
Gecko/20101011 Firefox/4.0b7pre Fennec/4.0b2pre 

Device Motorola Droid 2

Steps to reproduce:
1. Open Fennec
2. Assure you have some bookmarks 
3. Tap the awesome bar, go to bookmarks
4. long tap on a bookmark -> context menu appears -> select edit
5. choose one of the 3 input fields, tap it and try to enter some letters 

Expected result:
- the test enter should be present in the text input fields

Actual result:
- the focus moves in the url bar and yo are not able to modify the bookmark edit fields.

Note :
- behavior present also on Maemo
- tapping back brings you to the webpage not the bookmarks
Summary: can't edit the input fields for bookmark → Can't edit the input fields for bookmark
tracking-fennec: --- → 2.0b2+
Assignee: nobody → 21
Assignee: 21 → nobody
Component: General → Bookmarks
QA Contact: general → bookmarks
Assignee: nobody → 21
This is a recent regression. My builds from Oct 10 work fine. If I had to guess, I'd pick bug 596614.
Attached patch Patch (obsolete) — Splinter Review
This patch prevent the automatic editing of the urlbar to take effect if the selection is manual.
Attachment #483130 - Flags: review?(mark.finkle)
Comment on attachment 483130 [details] [diff] [review]
Patch

Components.interfaces.nsIFocusManager.FLAG_BYMOUSE -> Ci.nsIFocusManager.FLAG_BYMOUSE

And why does this work, but xxx.focus() does not? Tell me why this patch makes things work.
Attached patch Patch v0.2Splinter Review
The setFocus calls was too hacky and to disturbing, this patch use a completely different approach and move some code from browserUI.js to the urlbar-edit binding
Attachment #483130 - Attachment is obsolete: true
Attachment #483186 - Flags: review?(mark.finkle)
Attachment #483130 - Flags: review?(mark.finkle)
Attachment #483186 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/6d84cb3083a7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101015 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101015 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.