603611 - XPI's inside the extensions folder aren't getting installed correctly in older versions of Firefox

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10

With the placement of full XPI files in the extensions folder, older versions of Firefox do not install those extensions correctly:

* Extension without a GUID as id will not getting installed at all (i.e. Addons Compatibility Reporter)
* Inconsistent installation of multiple extensions with a GUID. Sometimes both, get installed. But mostly one or both get deleted (i.e. TwitterBar, RSS Ticker)

Looking at the log, there is nothing shown for an id like '[e-mail]' but as you can see below, the add-ons with a GUID have been lost:

*** EM_LOG *** A Item Package appeared at: /Users/henrik/Library/Application Support/Firefox/Profiles/2hqiufva.sdfg/extensions/{1a0c9ebe-ddf9-4b76-b8a3-675c77874d37}.xpi that we know nothing about, assuming it was dropped in by the user and configuring for installation now. Location Key: app-profile
*** EM_LOG *** A Item Package appeared at: /Users/henrik/Library/Application Support/Firefox/Profiles/2hqiufva.sdfg/extensions/{1f91cde0-c040-11da-a94d-0800200c9a66}.xpi that we know nothing about, assuming it was dropped in by the user and configuring for installation now. Location Key: app-profile
*** EM_LOG *** Item Uninstalled via file removal from: rel%{1a0c9ebe-ddf9-4b76-b8a3-675c77874d37} Item ID: {1a0c9ebe-ddf9-4b76-b8a3-675c77874d37} Location Key: app-profile, uninstalling item.
*** EM_LOG *** Item Uninstalled via file removal from: rel%{1f91cde0-c040-11da-a94d-0800200c9a66} Item ID: {1f91cde0-c040-11da-a94d-0800200c9a66} Location Key: app-profile, uninstalling item.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

I wasn't able to reproduce any issue with GUID named add-ons, but if there is an issue there it is going to be something different to the problem with email-style ID add-ons.

The branch assumes that any file that has a name matching the ID regexp can only be file pointers. This code simply drops through to allowing us to find them later as XPI files and extracts them. It also augments an existing test to verify it.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 484735 [details] [diff] [review]
patch rev 1

>diff --git a/toolkit/mozapps/extensions/src/nsExtensionManager.js.in b/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
>--- a/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
>+++ b/toolkit/mozapps/extensions/src/nsExtensionManager.js.in
>@@ -1222,20 +1222,21 @@ DirectoryInstallLocation.prototype = {
>           break;
>         entry instanceof Ci.nsILocalFile;
>         if (!entry.isDirectory() && gIDTest.test(entry.leafName)) {
>           var linkedDirectory = this._readDirectoryFromFile(entry);
>           if (linkedDirectory && linkedDirectory.exists() &&
>               linkedDirectory.isDirectory()) {
>             locations.push(linkedDirectory);
>             this._locationToIDMap[linkedDirectory.persistentDescriptor] = entry.leafName;
>+            continue;
>           }
>         }
>-        else
>-          locations.push(entry);
>+
>+        locations.push(entry);
>       }
>       entries.close();
nit: perhaps add a finally to the try block and move entries.close() to it?

Since this is the 1.9.2 branch I don't have a problem with not moving it.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 484735 [details] [diff] [review]
patch rev 1

I'd like to land this on the branches to make migration from Firefox 4 to previous versions a little nicer. Should be extremely low risk

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 484735 [details] [diff] [review]
patch rev 1

Approved for 1.9.2.12, a=dveditz for release-drivers

Comment 5

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/bb2e67d1661e

Henrik, if you can still see an issue with GUID extensions can you file a new bug.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12pre) Gecko/20101024 Namoroka/3.6.12pre

The installation works fine for both type of extension ids now. So there is no need for another bug.

What about the 1.9.1 branch? Do we also wanna have the fix landed there or do we only support the last branch?

Comment 7

[LegNeato]

Marking 1.9.1 as wonfix unless someone objects.