Closed
Bug 603724
Opened 14 years ago
Closed 14 years ago
widget/src/gtk2/nsWindow.cpp:293: warning: 'PRBool UseShm()' defined but not used
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.08 KB,
patch
|
cjones
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
> mozilla/widget/src/gtk2/nsWindow.cpp: At global scope:
> mozilla/widget/src/gtk2/nsWindow.cpp:293: warning: 'PRBool UseShm()' defined but not used
Looks like the only uses of this method are in #ifdef MOZ_HAVE_SHMIMAGE blocks. So, the method definition itself should probably be #ifdef'd, too.
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning]
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #482630 -
Flags: review?(jones.chris.g)
|
|
Assignee | |
Comment 2•14 years ago
|
||
(Confirmed that this builds successfully & fixes the build warning, on my machine)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 482630 [details] [diff] [review]
fix
So much for cutting down on ifdefs. |inline UseShm() {| would have worked too, but the other formerly non-ifdef'd uses of this function were requested to be ifdef'd in review, so this patch is better for consistency.
Attachment #482630 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 482630 [details] [diff] [review]
fix
Requesting approval.
Trivial change -- just adds #ifdefs around a static variable & method that are only used inside of other #ifdefs, to fix a build warning.
Attachment #482630 -
Flags: approval2.0?
Attachment #482630 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning] → [build_warning][needs landing]
|
|
Assignee | |
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][needs landing] → [build_warning]
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•