Closed Bug 603731 Opened 14 years ago Closed 14 years ago

mozilla/view/src/nsViewManager.cpp:603: warning: unused variable 'viewManager'

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

This checkin from bug 596414:
  http://hg.mozilla.org/mozilla-central/rev/9c33280093f8
introduced this GCC build warning:
> mozilla/view/src/nsViewManager.cpp:603: warning: unused variable 'viewManager'

That was from this chunk of the patch (which removes the only uses of |viewManager| without deleting the variable itself):
{
         nsViewManager* viewManager = view->GetViewManager();
-        if (viewManager->RootViewManager() == RootViewManager()) {
-          // get the damage region into view's coordinate system and appunits
-          nsRegion damage =
-            ConvertRegionBetweenViews(intersection, aWidgetView, view);
 
-          // Update the child and it's children
-          viewManager->
-            UpdateWidgetArea(view, childWidget, damage, aIgnoreWidgetView);
}
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch fixSplinter Review
Attachment #482635 - Flags: review?(joe)
Attachment #482635 - Flags: review?(joe) → review?(tnikkel)
Attachment #482635 - Flags: review?(tnikkel) → review+
Comment on attachment 482635 [details] [diff] [review]
fix

Requesting approval.  (Trivial change, to remove a no-longer-used variable.)
Attachment #482635 - Flags: approval2.0?
Attachment #482635 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/1d1667f9f519
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.