603731 - mozilla/view/src/nsViewManager.cpp:603: warning: unused variable 'viewManager'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

This checkin from bug 596414:
  http://hg.mozilla.org/mozilla-central/rev/9c33280093f8
introduced this GCC build warning:
> mozilla/view/src/nsViewManager.cpp:603: warning: unused variable 'viewManager'

That was from this chunk of the patch (which removes the only uses of |viewManager| without deleting the variable itself):
{
         nsViewManager* viewManager = view->GetViewManager();
-        if (viewManager->RootViewManager() == RootViewManager()) {
-          // get the damage region into view's coordinate system and appunits
-          nsRegion damage =
-            ConvertRegionBetweenViews(intersection, aWidgetView, view);
 
-          // Update the child and it's children
-          viewManager->
-            UpdateWidgetArea(view, childWidget, damage, aIgnoreWidgetView);
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 482635 [details] [diff] [review]
fix

Requesting approval.  (Trivial change, to remove a no-longer-used variable.)

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/1d1667f9f519