Closed Bug 603804 Opened 9 years ago Closed 9 years ago

Don't include add-ons in fragment when metadata updates are disabled

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: fligtar, Assigned: mossop)

Details

Attachments

(1 file)

If the user has turned off metadata updates for add-ons in Firefox, we should also no longer show them personal recommendations. In order to make this opt-out process as easy as possible and retain state, we should make this same action turn off Discovery Pane's knowledge of what add-ons are installed.

So if the user has turned off metadata updates, we should not append the installed add-ons fragment to the Discovery Pane URL.
blocking2.0: --- → ?
blocking2.0: ? → final+
If you're looking for another easy fix Margaret, this is such a bug.
Whiteboard: [good first bug]
Assignee: nobody → dtownsend
Whiteboard: [good first bug]
Attached patch patch rev 1Splinter Review
Pretty straightforward, also added better testing that the hash data contains what we would expect.
Attachment #488226 - Flags: review?(bmcbride)
Whiteboard: [has patch][needs review Unfocused]
Attachment #488226 - Flags: review?(bmcbride) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/25f346a28ba8
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review Unfocused]
Target Milestone: --- → mozilla2.0b8
Dave, as it looks like we only check for the background update pref but do not take into account extensions.getAddons.cache.enabled. Users can still have automatic updates enabled for all add-ons but don't want to let the add-on meta data updated. In those cases we still send all the information to the Discovery Pane.
That's true but as we don't expose that setting in the UI I don't think it is much of an issue.
(In reply to comment #5)
> That's true but as we don't expose that setting in the UI I don't think it is
> much of an issue.

Ok, I have checked the updated privacy policy (http://www.mozilla.com/en-US/legal/privacy/firefox.html) for Firefox and found the following sentence:

This communication only happens when the Get Add-ons area is open and can be turned off at any time by opting out of Automatic Updates from the Add-ons Manager.

So you are right, and we should only stop sending fragments when the user has been opt-out from automatic updates. I will retest now.
As talked with Dave on IRC we have a pretty broken strategy here and the privacy policy is also wrong in some points. Dave will come up with a proposal later today.
Ok, so disabling sending the fragments only works by setting extensions.update.enabled to false at the moment. That's not what we want in general and will be covered by bug 635115.

Verified fixed based on the manual setting of the preference with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b12pre) Gecko/20110216 Firefox/4.0b12pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.