603865 - Revive AOT compiler

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Alex Macdonald]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-us) AppleWebKit/533.18.1 (KHTML, like Gecko) Version/5.0.2 Safari/533.18.5
Build Identifier: 

Changes to the VM since we stopped working on the AOT compiler have caused it to bitrot, this patch fixes those issues. It's mostly minor tweaks, the only interesting changes that affected us was some refactoring to the way activation traits get hooked up and the where the native method thunker is stored. 

Reproducible: Always

Comment 1

[Alex Macdonald]

Attachment: Revive AOT patch

Comment 2

[Steven Johnson]

Comment on attachment 482776 [details] [diff] [review]
Revive AOT patch

Adding Rick to review the nanojit changes (which are trivial but would need to be pushed separately)

Comment 3

[Rick Reitmaier]

Comment on attachment 482776 [details] [diff] [review]
Revive AOT patch

pushed NJ change : http://hg.mozilla.org/projects/nanojit-central/rev/1cdb89db3ab9

Comment 4

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/3ea8cbaeb0e4

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/3ea8cbaeb0e4

Comment 6

[David Saracino]

Attachment: Fixed and excluded a few AOT tests

Fixed compilation of pre-built abcs - with the .abc_ extension.  Also excluded more tests from AOT build.

Comment 7

[Nicholas Nethercote [inactive]]

(In reply to comment #6)
> Created attachment 485101 [details] [diff] [review]
> Fixed and excluded a few AOT tests
> 
> Fixed compilation of pre-built abcs - with the .abc_ extension.  Also excluded
> more tests from AOT build.

Please file this as a separate bug.  Filing a new bug is cheap, and having one patch per bug makes tracking and merging easier.  This is doubly true when the bug is already RESOLVED FIXED when a second patch is attached.

Comment 8

[Steven Johnson]

Comment on attachment 485101 [details] [diff] [review]
Fixed and excluded a few AOT tests

Looks OK to me, adding cpeyer

Comment 9

[Chris Peyer]

Comment on attachment 485101 [details] [diff] [review]
Fixed and excluded a few AOT tests

> +        precompiledExt = ".abc_"

Should move abcOnlyExt (which defines the same string) from acceptance/runtests.py to runtestBase instead of defining a new var

For the code block in compileWithAsh:

> +                settings = self.getLocalSettings(testdir)

should be prefaced with a if self.aotsdk: check so that the code is only run then.

Is aot only run with --rebuildtests and without the pexpect module installed?  Because that is the only way that this code will be run.

Comment 10

[Alex Macdonald]

I've filed a separate bug with fixed version of David's patch here 606738. David when you get a chance can you mark the patch you attached here as obsolete?

(In reply to comment #9)
> Is aot only run with --rebuildtests and without the pexpect module installed? 

yes, because of the way AOT works a change in the runtime requires a recompilation of every test.

Comment 11

[David Saracino]

Comment on attachment 485101 [details] [diff] [review]
Fixed and excluded a few AOT tests

Marking as obsolete.  Problem now tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=606738

Comment 12

[Steven Johnson]

TR 5389:e973f9660ad1

Comment 13

[Rick Reitmaier]

nanojit-change : http://hg.mozilla.org/tamarin-redux/rev/a7313158044c