603876 - No support for addjovi and subjovi on Sparc platform

Status: RESOLVED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

Description

[William Maddox]

An attempt to use the LIR_addjovi instruction results in an assertion:
Assertion failure: "Unsupported": 0 (/export/home/build/wmaddox/tr-add/nanojit/NativeSparc.cpp:707)

It appears that there is no support for LIR_addjovi and LIR_subjovi in Assembler::asm_arith(), in file "NativeSparc.cpp".  Interestingly,
there appears to be support for LIR_muljovi.

Comment 1

[Edwin Smith]

Does this block any bugs (the inline optimizations)?  Unsupported instructions shouldn't be emitted by the front end, see Native.h for example #ifdef switches that control optional groups of LIR instructions.

Of course it's desirable to have these work cross-platform, but the ifdefs make implemenating one backend at a time feasible.

Comment 2

[William Maddox]

This bug was filed in response to the following comment:

https://bugzilla.mozilla.org/show_bug.cgi?id=561249#c30

It prevents speculative inlining of addition, bug 561249,
but that patch correctly takes platform support into account.

Comment 3

[Ginn Chen]

I've a fix in my workspace.

Comment 4

[William Maddox]

(In reply to comment #3)
> I've a fix in my workspace.

Please post a patch, after verifying that the "make check" tests pass.
Thanks.

Comment 5

[Ginn Chen]

Attachment: patch

This will fix several fails in make check.

I'm working on the other fails. (NJ_EXPANDED_LOADSTORE_SUPPORTED, etc.)
I already have several patches in my workspace.
I'll post my patches after fixing Bug 602388.

Comment 6

[Ginn Chen]

http://hg.mozilla.org/projects/nanojit-central/rev/d372626d5b87

Comment 7

[Rick Reitmaier]

http://hg.mozilla.org/tamarin-redux/rev/0add807ba191

Comment 8

[Dan Smith]

Ginn, can you confirm this has landed in MC and can be resolved?

Comment 9

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/ae9485688a0f