Closed
Bug 603914
Opened 14 years ago
Closed 14 years ago
test-traceback fails with '"throwError" != "Error"' and '"" != "throwError"'
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Assigned: myk)
Details
Attachments
(1 file)
819 bytes,
patch
|
avarma
:
review+
|
Details | Diff | Splinter Review |
On trunk nightly builds, test-traceback fails with '"throwError" != "Error"' and '"" != "throwError"': error: fail: "throwError" != "Error" info: Traceback (most recent call last): File "resource://jetpack-core-jetpack-core-lib/timer.js", line 64, in notifyOnTimeout this._callback.apply(null, this._params); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous timer.setTimeout(function() { onDone(self); }, 0); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest self.start({test: test, onDone: runNextTest}); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start this.test.testFunction(this); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest test(runner); File "resource://jetpack-core-jetpack-core-tests/test-traceback.js", line 66, in anonymous "Error"); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual this.fail(message); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail console.trace(); error: fail: "" != "throwError" info: Traceback (most recent call last): File "resource://jetpack-core-jetpack-core-lib/timer.js", line 64, in notifyOnTimeout this._callback.apply(null, this._params); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous timer.setTimeout(function() { onDone(self); }, 0); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest self.start({test: test, onDone: runNextTest}); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start this.test.testFunction(this); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest test(runner); File "resource://jetpack-core-jetpack-core-tests/test-traceback.js", line 68, in anonymous "throwError"); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual this.fail(message); File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail console.trace(); This is due to changes in the content of stack traces from "slow-native removal", as described in bug 603849, comment 4. Here's the trivial fix that updates the test to take those changes into account. See also <http://groups.google.com/group/mozilla.dev.tech.js-engine/browse_thread/thread/c1d4b5bf54e47bb5#c658f4885d06e7a0> for a before and after comparison of stack traces.
Attachment #482809 -
Flags: review?(avarma)
Comment 1•14 years ago
|
||
Comment on attachment 482809 [details] [diff] [review] patch v1: addresses problem Looks great to me, thanks for the fix!
Attachment #482809 -
Flags: review?(avarma) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/ac92e9e6409c.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•14 years ago
|
||
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product. To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
You need to log in
before you can comment on or make changes to this bug.
Description
•