603944 - (fx40-p12n-bg) [bg] Firefox 4.0 productization review for Bulgarian

Status: RESOLVED FIXED

(Mozilla Localizations :: bg / Bulgarian, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Bulgarian and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/bg>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Bulgarian builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

The Bloglines change does not affect your locale. 

However, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central. 

If there are not changes, just close this bug.  Thank you.

Comment 2

[Seth Bindernagel]

I am resolving this bug as fixed since the Bloglines change does not affect your locale.

If you'd like to make some changes to your locale's productization elements for Firefox 4, please reopen this bug.  But, do not hesitate since we are closing in on a release candidate and will not take p12n changes after that point.

Comment 3

[Axel Hecht [:Pike]]

Reopening. There's two changesets to region.properties that went in without review, and I'm not sure they're correct.

http://hg.mozilla.org/l10n-central/bg/diff/6b5dd0e81a34/browser/chrome/browser-region/region.properties changed the handlers, which may or may not be right, but it didn't update the defaultHandlersVersion.

http://hg.mozilla.org/l10n-central/bg/diff/eb8a96d0f1b7/browser/chrome/browser-region/region.properties killed netvibes, and added search order for bing (there's no bing in search, though). Probably just tool error.

I'm making a *really* far fetched call here and take the current sign-off despite the problems here, but I want a good state of region.properties for release.

Comment 4

[Ognyan Kulev]

I reverted to changeset before these 2 changes. Compare-locales now complains about extra keyword.URL and missing browser.search.siteSearchURL. The relevant diff in the revert commit is:

-# URL for site-specific search engines
-# TRANSLATION NOTE: {moz:domain} and {searchTerms} are placeholders for the site
-# to be searched and the user's search query. Place them in the appropriate location
-# for your locale's URL but do not translate them.
-browser.search.siteSearchURL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&q=site%3A{moz:domain}+{searchTerms}
+# Keyword URL (for location bar searches)
+keyword.URL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=

Should I remove keyword.URL and add browser.search.siteSearchURL?

Seth wrote me a letter almost a month ago about adding pazaruvaj.com and aukro.bg web services. I don't think the first site is significant enough but aukro.bg is the leader in its market and I think it's worth adding. Is it too late for Firefox 4?

Comment 5

[Seth Bindernagel]

Axel?  I think I might be too late to add aukro.bg, but we might be able to get it in there since it is a relatively known change.  Please provide a patch ASAP.  Axel and I will determine what is best.

Comment 6

[Axel Hecht [:Pike]]

RC is 10 days out, that's the target that Damon has posted in .planning. Kinda depends on how responsive the people are at aukro.bg.

Comment 7

[Seth Bindernagel]

Ogi, please provide a patch and let's plan to proceed.  Aukro.bg is OK with being included as they emailed me directly.

Comment 8

[Ognyan Kulev]

Attachment: Removing keyword.URL and adding siteSearchURL

I've already reverted back to changeset c52a798c5ae4 and here's a patch for bringing bg's region.properties to current state in mozilla-central - removing keyword.URL and adding siteSearchURL (comment 4).

Comment 9

[Seth Bindernagel]

Comment on attachment 513952 [details] [diff] [review]
Removing keyword.URL and adding siteSearchURL

Looks good. Please land on l10n-central and then test (by making sure nothing is broken) the nightly build.  If all is good, then sign off.  Then close this bug.

Comment 10

[Ognyan Kulev]

I've committed the patch and tested if something breaks. Everything looks fine.

Then I tried to use this siteSearchURL but I found that in mozilla-central there's no code that uses this preference :-) Same for keyword.URL (except some testing scripts).

It seems that sign-offs are closed now for 4.0.

Comment 11

[Axel Hecht [:Pike]]

Sign-offs are open again. And yes, the siteSearchURL is unused, bug 482229.