603964 - (fx40-p12n-fi) [fi] Firefox 4.0 productization review for Finnish

Status: RESOLVED FIXED

(Mozilla Localizations :: fi / Finnish, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Finnish and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/fi>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Finnish builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Ville Pohjanheimo (inactive)]

* protocol handlers,
 - Still ok 
* feed readers,
 - Current defaults work well. (Netvibes, My yahoo, google)
* live bookmark.
 - Yle.fi -- Finnish national broadcaster. Still perfect.
* search engines,
 - I'd like remove creative commons (relevance, not localized) and add bing (well localized service)

If given the choice I'd also remove searchplugins bookplus-fi and huuto.net. Both are unimpressive and not-developed sites that do not really deserve our support. However there are no other local substitutes for these sites. Amazon(.co.uk) though could replace bookplus.fi especially that they now offer free delivery to Finland.

I'll make a patch once I hear from you.

Comment 2

[Seth Bindernagel]

These changes sound very appropriate.  Please attach a patch, flagging me (:sethb) for a review.  Once I approve that, you can land it on l10n-central.

Comment 3

[Ville Pohjanheimo (inactive)]

Attachment: All suggested changes

Seth: I didn't make it clear enough, but I meant to ask if I could also remove bookplus and huuto for the given reasons.

This patch (All suggested changes) has all the changes (listed below). 

* Add bing (inc. changes in browser-region/region.properties to parity with en-US)
* Amazon.co.uk to replace bookplus (shopping site)
* Remove CC, Huuto.net and Bookplus.fi

I will next attach a reduced patch set that will only remove cc and add bing. Approve either one seems more approriate. Thanks.

Comment 4

[Ville Pohjanheimo (inactive)]

Attachment: Reduced change set

Comment 5

[Ville Pohjanheimo (inactive)]

It appears eBay has just made a localized Finnish site. Given that, I'd like to replace huuto.net with ebay.fi. Ebay easily provides superior quality of service to Finnish users.

I'll redo the patches soon, so hold review, thanks.

Comment 6

[Seth Bindernagel]

Acknowledging this and waiting for your patch.

Comment 7

[Ville Pohjanheimo (inactive)]

Attachment: All suggested changes, ebay.fi added compared to last set

Comment 8

[Ville Pohjanheimo (inactive)]

Attachment: Reduced set with ebay.fi added

Here's the reduced patch option.

I favour the full set. That one adds ebay.fi, bing and Amazon UK, removes huuto.net (old auction), bookplus.fi (bookstore) and creative commons. Rationale given earlier. The reduced set does not add Amazon UK and doesn't remove bookplus.fi.

Comment 9

[Seth Bindernagel]

Comment on attachment 492174 [details] [diff] [review]
All suggested changes, ebay.fi added compared to last set

eBay and Amazon both have partnerships with Mozilla.  We will need to add one more piece to each search plugin.  I will r- this for now and respond in the bug with the information you'll need to make the plugin complete.  Thanks for the patience.

Comment 10

[Kev Needham [:kev]]

Attachment: eBay FI search plugin

Updated eBay plugin for FI, per eBay's instructions.

Comment 11

[Kev Needham [:kev]]

Attachment: Updated eBay fi search plugin

and we'll try that again.

Comment 12

[Seth Bindernagel]

Comment on attachment 503209 [details] [diff] [review]
Updated eBay fi search plugin

This looks good.  Ville, please check this into your l10n-central repository.  This is the eBay search plugin that we have been waiting for from Kev.

When you check it in, add a comment that references bug 603694, r=sethb, and the change.  After that, please test and then sign off.  Don't forget to sign off or the changes will not get picked up.

Comment 13

[Seth Bindernagel]

Comment on attachment 492175 [details] [diff] [review]
Reduced set with ebay.fi added

Everything looks good here, EXCEPT that it contains your version of the eBay plugin.  Please use the plugin provided by Kev in this bug.  We will need a new patch with these changes, not including your version of the eBay plugin.  Please upload again and ask me for a review.

Comment 14

[Ville Pohjanheimo (inactive)]

Attachment: Reduced set v2 with ebay.fi removed

I've removed ebay from this patch as Kev's patch takes care of that.

Comment 15

[Seth Bindernagel]

Comment on attachment 507176 [details] [diff] [review]
Reduced set v2 with ebay.fi removed

I prefer that you not remove the localization note, but you might be using a tool that does that for you.  That's OK if you do that.

You can land this on l10n-central. When you do, can you add a comment that states the following: "Bug 603664: FF 4 productization changes, r=sethb"

Once you land this, can you test it?  If the testing goes well, then sign off.  Don't forget to sign off or the changes will not get picked up in the next beta release.

After all goes well, please resolve this bug as fixed.

Thanks!

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 507176 [details] [diff] [review]
Reduced set v2 with ebay.fi removed

This broke the builds, 

diff --git a/browser/searchplugins/list.txt b/browser/searchplugins/list.txt
--- a/browser/searchplugins/list.txt
+++ b/browser/searchplugins/list.txt
@@ -1,6 +1,6 @@
+bing
 bookplus-fi
-creativecommons-fi
-huuto-fi
 google
+ebay-fi
 wikipedia-fi
 yahoo-fi

ebay-fi needs to be eBay-fi, to match the filename.

Comment 17

[Seth Bindernagel]

Good catch, Pike!  Ville please note the case of the "B" in "eBay-fi".  That broke the build and I didn't catch that error.  You can check-in that fix without a review.  Please test and sign off on that change.

Comment 18

[Seth Bindernagel]

Looks like this is changed.