Bug 603973 (fx40-p12n-hi-IN)

[hi-IN] Firefox 4.0 productization review for Hindi (India)

RESOLVED WONTFIX

Status

Mozilla Localizations
hi-IN / hindi
RESOLVED WONTFIX
8 years ago
3 years ago

People

(Reporter: stas, Unassigned)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Update l10n-src-verif])

Attachments

(3 attachments)

(Reporter)

Description

8 years ago
As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Hindi (India) and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/hi-IN>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Hindi (India) builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

8 years ago
Created attachment 503183 [details] [diff] [review]
Updated eBay search plugin

Reopening (sorry)

Per eBay's request, please update the search plugin to be included with Mozilla
products per the attached patch. The changes add suggested search, an updated
favicon, and changes the base search URL. This change will normalize the
version of eBay's plugin for India, and should block Fx4 for all *-IN locales
that include eBay. Note that any previously included params should not
be re-introduced.

If there are any questions, please let me know.
Attachment #503183 - Flags: review?(sethb)

Updated

8 years ago
Blocks: 625062

Comment 2

8 years ago
Created attachment 505382 [details] [diff] [review]
patch after removing amazon, ebay and adding bing
Attachment #505382 - Flags: review?

Comment 3

8 years ago
Comment on attachment 503183 [details] [diff] [review]
Updated eBay search plugin

This looks good.  Thank you, Kev!

Rajesh, as mentioned in the bug, can you please check this into your
l10n-central repository.  Please test the new build and sign off.  Once you
have signed off, please resolve this bug again as fixed.

Thanks to all.
Attachment #503183 - Flags: review?(sethb) → review+

Updated

8 years ago
Whiteboard: [Update l10n-src-verif]

Comment 4

8 years ago
Comment on attachment 505382 [details] [diff] [review]
patch after removing amazon, ebay and adding bing

I think we want to keep eBay-in given the partnership we have with them.  If you strongly oppose this, then please speak up.  Otherwise, I am going to r- this one and ask you to leave it in, submitting a new patch that only removes amazondotcom.  Any thoughts?
Attachment #505382 - Flags: review? → review-

Comment 5

8 years ago
Created attachment 505741 [details] [diff] [review]
patch for review for hindi

sorry. again submitting!
Attachment #505741 - Flags: review?

Comment 6

8 years ago
Comment on attachment 505741 [details] [diff] [review]
patch for review for hindi

OK, this looks good.  Please check this patch AND the ebay plugin patch that has an r+ into l10n-central.  

When you check this those two changes, add a comment that states the following: "Bug 603973: Adding new eBay-in plugin, updating list.txt to include Bing, r=sethb"

Afterward, please test, and if all goes well then sign off.  Don't forget to sign off or we won't pick up the changes. :)

After signoff, please resolve this bug as fixed.
Attachment #505741 - Flags: review? → review+

Comment 7

8 years ago
completed. Signed off!
Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.
Can we resolve this, based on comment 7?

Comment 10

8 years ago
Sign-off taken, marking FIXED.

Rajesh, feel free to get a patch for the type removal into a new bug, CC sethb?
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 11

8 years ago
(In reply to comment #8)
> Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the
> search service does not make use of the "type" attribute on Image elements. You
> should feel free to remove it.

Its not there?

http://hg.mozilla.org/l10n-central/hi-IN/file/265605bffc02/browser/searchplugins/eBay-in.xml

Comment 12

8 years ago
(In reply to comment #8)
> Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the
> search service does not make use of the "type" attribute on Image elements. You
> should feel free to remove it.

When I look here

http://hg.mozilla.org/l10n-central/hi-IN/file/265605bffc02/browser/searchplugins/eBay-in.xml

I only see "data:image/x-icon" on the <Image>.  I am not exactly sure what Gavin is referring to here.  Does that get removed?

Comment 14

8 years ago
Reopening, the eBay-in change apparently did not land.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 15

8 years ago
We should this ASAP, but 4.0.1 is early enough according to Kev.

Comment 16

3 years ago
Resolving this one! 

If there is any need to open this again then please suggest!

Thanks
Umesh Agarwal
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.