603974 - (fx40-p12n-hr) [hr] Firefox 4.0 productization review for Croatian

Status: RESOLVED FIXED

(Mozilla Localizations :: hr / Croatian, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Croatian and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/hr>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Croatian builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it. 

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.

Comment 2

[Seth Bindernagel]

Ping.

Comment 3

[Sasa Tekovic]

Hi Seth,

sorry for the delay. I just noticed this bug report.

1. google.xml doesn't exist in croatian (hr) repo, so there's nothing to do here.

2. I'll need some help with removal of Bloglines for croatian locale and promotion of Google Reader to the first position. Is it enough to make this changes in /browser/chrome/browser-region/region.properties ?

3. I've removed creative-commons and added bing to /browser/searchplugins/list.txt
Is this enough or do I need to do some other changes?

Cheers!

Comment 4

[Seth Bindernagel]

(In reply to comment #3)
> Hi Seth,
> 
> sorry for the delay. I just noticed this bug report.
> 
> 1. google.xml doesn't exist in croatian (hr) repo, so there's nothing to do
> here.
>

Thank you for checking and confirming.
 
> 2. I'll need some help with removal of Bloglines for croatian locale and
> promotion of Google Reader to the first position. Is it enough to make this
> changes in /browser/chrome/browser-region/region.properties ?

Yes, it is a simple change to the region.properties file.  You will need to prepare a patch for both 1.9.2 and 2.0.

> 
> 3. I've removed creative-commons and added bing to
> /browser/searchplugins/list.txt
> Is this enough or do I need to do some other changes?

That should work fine.  

After you prepare the patches above that I can review, you will need to land, text and then sign off so we can pick up the changes.  Be sure to do this soon as we are closing in on the 4.0 release.

Thanks!

Comment 5

[Sasa Tekovic]

Attachment: region.properties patch for 1.9.2

Comment 6

[Sasa Tekovic]

Attachment: region.properties patch for 2.0

Comment 7

[Sasa Tekovic]

Hi Seth,

here are the patches. Let me know if everything is OK.

What's the next move? Will there be another revision after you review the patches that I'll need to sign off?

Cheers!

Comment 8

[Seth Bindernagel]

Comment on attachment 512764 [details] [diff] [review]
region.properties patch for 1.9.2

Please land this on 1.9.2.  Add the following comment:  "Bug 603974. r=sethb, remvoving bloglines."

After you land on 1.9.2 and test your nightly build, please sign off using the sign off app.

Comment 9

[Seth Bindernagel]

Comment on attachment 512765 [details] [diff] [review]
region.properties patch for 2.0

Please land this on l10n-central.  Add the same type of comment for the commit message that you used for 1.9.2.

Once landed, please test and then sign off on the acceptable build.  

Resolve this bug as fixed when you are finished.

Comment 10

[Sasa Tekovic]

Hi Seth,

since this is my first time doing this sort of thing and I'm not quite familiar with terminology, I suppose that by "landing" you meant committing and pushing the patched version of files to the server?

Thanks!

Comment 11

[Seth Bindernagel]

Hi Sasa, yes, sorry for using unfamiliar terminology.  Please commit your patch and then push to your hr mercurial repository on hg.mozilla.org.  You will need to push your changes to both 1.9.2 and l10n-central.  Then, don't forget to use Pike's sign off application after you have tested.  If all looks good, you can close this bug.

Comment 12

[Sasa Tekovic]

Hi Seth,

you don't need to apologize for anything. I have to learn things sooner or later :-)

Patches are landed, tested in nightly builds and signed off.

I'd gladly mark this bug as fixed, but it seems I don't have the necessary permissions to do that. Should I contact someone about that or I'm I doing something wrong? Bellow "Additional comments" textbox I have "Status:NEW" message, but there is no dropdown menu to change bug status :-/

Cheers!

Comment 13

[Axel Hecht [:Pike]]

Sasa, I updated your privs, please use them carefully.

Comment 14

[Sasa Tekovic]

Thx Pike, duly noted.
I'm marking this bug as fixed.