Closed Bug 604000 (fx40-p12n-or) Opened 9 years ago Closed 9 years ago

[or] Firefox 4.0 productization review for Oriya

Categories

(Mozilla Localizations :: or / Odia, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Unassigned)

References

Details

(Keywords: productization, Whiteboard: [l10n-src-verification updated])

Attachments

(4 files, 4 obsolete files)

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Oriya and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/or>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Oriya builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it.  However please note the new update about Bloglines below.

Mozilla has been contacted by the new owners of Bloglines who have said they will keep the service running.  If you have no other options, you can consider leaving it.  However, it is hard to say whether that team who is now in control of Bloglines will change their mind again.  The l10n-drivers feel that it would be best to remove it altogether.

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.
Regarding search, can I dump into this bug that we still have the old icon for yahoo on l10n-central here?
(In reply to comment #2)
> Regarding search, can I dump into this bug that we still have the old icon for
> yahoo on l10n-central here?

I haven't been tracking that in other bugs, but if it is a known productization issue for Firefox 4, then I guess we should take care of it, too.  Do you want to dupe that bug with this bug number?  

Manoj, we'll need to make the Yahoo icon change here.  Please note that and make the change.  You can reference the other bug number that Axel will provide.  (either as a dupe or as a copy/paste)
Hi Seth, I'm providing you the patch for yahoo-in.xml for verification.
Also i've added bing into my existing list.txt file.(not yet committed).
Let me know if anything else i need to do.
Added "bing" into the list.txt file under searchplugins.
Removed "bloglines" from the file region.properties.
Removed "Bloglines" from region.properties under /l10n-mozilla-1.9.2/or.
Comment on attachment 492616 [details] [diff] [review]
patch for  region.properties for Oriya Language [l10n-mozilla-1.9.2/or]

You don't want to include this:

+# browser.contentHandlers.types.0.title=Bloglines
+# browser.contentHandlers.types.0.uri=http://www.bloglines.com/login?r=/sub/%s

You should move the Google handler to the "0" position and be sure not to place a # in the line.
Attachment #492616 - Flags: review-
Comment on attachment 492615 [details] [diff] [review]
patch for  region.properties for Oriya Language [or]

Same feedback as the 1.9.2 patch.
Attachment #492615 - Flags: review-
Comment on attachment 492614 [details] [diff] [review]
patch for  list.txt for Oriya Language [or]

This looks good and you can include it in one patch for l10n-central once you fix the region.properties file.  Just hg diff all the changes and save that as a patch that you attach for the entire set of changes.  

If you don't want to do that, you can commit this patch, adding a comment that references bug 604000.

Thanks.
Attachment #492614 - Flags: review+
Comment on attachment 492594 [details] [diff] [review]
patch for yahoo-in.xml for Oriya Language [or]

Let's use Params for this line:

+<Url type="application/x-suggestions+json" method="GET"
+     template="http://ff.search.yahoo.com/gossip?output=fxjson&amp;command={searchTerms}" />

Please attach a new patch that looks like this:

<Url type="application/x-suggestions+json" method="GET" template="http://ff.search.yahoo.com/gossip"/>
<Param name="output" value="fxjson"/>
<Param name="command" value="{searchTerms}"/>
Attachment #492594 - Flags: review-
(In reply to comment #11)
> Please attach a new patch that looks like this:
> 
> <Url type="application/x-suggestions+json" method="GET"
> template="http://ff.search.yahoo.com/gossip"/>
> <Param name="output" value="fxjson"/>
> <Param name="command" value="{searchTerms}"/>

A small error here, this should be:

<Url type="application/x-suggestions+json" method="GET" template="http://ff.search.yahoo.com/gossip">
  <Param name="output" value="fxjson"/>
  <Param name="command" value="{searchTerms}"/>
</Url>

The <Param/> elements need to be inside the <Url/> element.
Modified region.properties in 1.9.2 for Oriya Language.
Also added Bing into the search engine order.
Attachment #492616 - Attachment is obsolete: true
Modified region.properties in mozilla-central for Oriya Language.
Also added Bing into the search engine order.
Attachment #492615 - Attachment is obsolete: true
Modified yahoo-in.xml as per the suggestion for mozilla-central.
Kindly advice me if i need to make this changes in 1.9.2.

Thanks!
Attachment #492594 - Attachment is obsolete: true
Comment on attachment 493941 [details] [diff] [review]
Modified patch for yahoo-in.xml for Oriya Language [or]

r=me, thanks. You could probably fit 

<Url type="application/x-suggestions+json" method="GET"
template="http://ff.search.yahoo.com/gossip">

in one line, but it's fine in two lines, too.

Re landing this on 1.9.2, that very change landed on 1.9.2/or in bug 531660, so we're good.
Attachment #493941 - Flags: review+
Comment on attachment 493933 [details] [diff] [review]
patch for  region.properties for Oriya Language [or]

If you're adding 

   browser.search.order.3=Bing

you'll also need to amend list.txt and add "bing" there, too. Please attach a new patch. Thanks.
Attachment #493933 - Flags: review-
Comment on attachment 493931 [details] [diff] [review]
patch for  region.properties for Oriya Language [l10n-mozilla-1.9.2/or]

Please don't add Bing on 1.9.2.
Attachment #493931 - Flags: review-
(In reply to comment #17)
> Comment on attachment 493933 [details] [diff] [review]
> patch for  region.properties for Oriya Language [or]
> 
> If you're adding 
> 
>    browser.search.order.3=Bing
> 
> you'll also need to amend list.txt and add "bing" there, too. Please attach a
> new patch. Thanks.

"bing" is already in list.txt. Please check in # Comment5.
Removed "browser.search.order.3=Bing" entry from region.properties for 1.9.2/or.
Attachment #493931 - Attachment is obsolete: true
Comment on attachment 494322 [details] [diff] [review]
patch for  region.properties for Oriya Language [l10n-mozilla-1.9.2/or]

This looks good.   When you land this on 1.9.2, please add a comment that references the change and bug 604000.  Please add r=sethb.  And, after you test your nightly, please sign off so the update gets picked up on the next minor release of Firefox 3.6.
Attachment #494322 - Flags: review+
Whiteboard: [update l10n-src-verification]
(In reply to comment #21)
> Comment on attachment 494322 [details] [diff] [review]
> patch for  region.properties for Oriya Language [l10n-mozilla-1.9.2/or]
> 
> This looks good.   When you land this on 1.9.2, please add a comment that
> references the change and bug 604000.  Please add r=sethb.  And, after you test
> your nightly, please sign off so the update gets picked up on the next minor
> release of Firefox 3.6.

Landed in l10n-mozilla-1.9.2/or. Revision: 1c60c3ccc61c

Thanks!
Thanks, Manoj.

When you sign off on the 1.9.2 build you want to ship, please close this bug.
Landed yahoo-in.xml for l10n-central/or : Rev-9928239f9465
Landed list.txt for l10n-central/or : Rev-cc710e8e7a3e

Waiting for region.properties for l10n-central to be reviewed.(attachment
493933 [review])
Comment on attachment 493933 [details] [diff] [review]
patch for  region.properties for Oriya Language [or]

This looks good to land on l10n-central.  Please add the comment referencing bug 60400 and the change and r=sethb.   When you land, don't forget to signoff.
Attachment #493933 - Flags: review- → review+
(In reply to comment #19)
> "bing" is already in list.txt. Please check in # Comment5.

Ah right, sorry for missing it. It's usually better to attach a single patch for all modified files. This makes it easier to review the changes :)

(And thanks, Seth, for r+'ing that patch.)
Landed region.properties for l10n-central/or: rev- 8e831f71db31

Thanks a lot!
Marking as fixed, thanks Manoj!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [update l10n-src-verification] → [l10n-src-verification updated]
You need to log in before you can comment on or make changes to this bug.