604058 - Fonts on some sites are smudgy and green either all the time or when loading/scrolling

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[IU]

On a Windows 7 x64 system with intel graphics, blue fonts on certain sites end up being a smudgy greenish blue.

On the following page, the regression is apparent always: http://wiki.mikrotik.com/wiki/Bandwidth_Managment_and_Queues

On this page, the regression is apparent when loading or scrolling, disappearing 4 seconds after a load/scroll event: http://www.dlink.ca/products/category/?cid=15#sub_127

There is no workaround, as there are no updated display drivers for my system.  I've already beat this dead horse.

Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9024046121ca&tochange=05ea34e1b2a1

Likely cause: bug 600908

Hardware Platform:
Dell Vostro Notebook 3500
Intel Core i3 M350
Intel HD Graphics (river version: 8.15.10.2119)

Comment 1

[Joe Drew (not getting mail)]

IU, can you also paste the graphics section of about:support?

Comment 2

[IU]

Graphics

Adapter Description Intel(R) HD Graphics
Vendor ID8086
Device ID0046
Adapter RAM Unknown
Adapter Driversig dumd64 igd10umd64 igdumdx32 igd10umd32
Driver Version8.15.10.2119
Driver Date4-21-2010
Direct2D Enabled false
DirectWrite Enabled false
GPU Accelerated Windows 0/2

Comment 3

[Joe Drew (not getting mail)]

Hm. It seems unlikely that just making shadowable layers retained would cause this, but maybe? Chris, any ideas?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Oh fffuuu.  That condition should have been |&& (!AsShadowableLayer() || !AsShadowableLayer()->HasShadow())|.  Review fail.  (No tests for this rendering case?)

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Shadowable layers might not have shadows

Comment 6

[Joe Drew (not getting mail)]

Comment on attachment 482918 [details] [diff] [review]
Shadowable layers might not have shadows

Can you rewrite the condition as !(AsShadowableLayer() && AsShadowableLayer()->HasShadow()) so it's a little easier to read/understand?

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Sure.  Oh, and before I break builds, this also needs to be

  !(AsShadowableLayer() &&
#ifdef MOZ_IPC
    AsShadowableLayer()->HasShadow()
#else
    false
#endif
  )

Still OK or would you prefer a refactoring to avoid the extra ifdef?  (Say, to add CantNotRetain() or something.)

Comment 8

[Joe Drew (not getting mail)]

May as well just factor it out while you're in here, and then I can rereview.

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Shadowable layers might not have shadows

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/9ff275aeb41f

Comment 11

[IU]

Verified fixed with: http://hg.mozilla.org/mozilla-central/rev/675c7c026824
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre

Thanks