60406 - javascript error in charsetOverlay.js (line 126: wnd has no properties ) after turning off sidebar and toolbars

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Matt]

1. start a fresh run of the browser
2. toggle View-->Toolbars-->Personal Toolbar off
3. toggle View-->Toolbars-->Taskbar off
4. toggle View-->My Sidebar off
5. Select View-->Character Coding-->Auto-detect

Result:
The following message is output:
"JavaScript error:
chrome://global/content/charsetOverlay.js line 126: wnd has no properties"

Comment 1

[Asa Dotzler [:asa]]

over to i18n
Confirmed with build 111704 on NT

Comment 2

[nhottanscp]

Reassign to cata.

Comment 3

[Henrik Gemal]

To reproduce, just do:
Select View-->Character Coding-->Auto-detect Off

Comment 4

[Frank Tang]

move all cata's bug to ftang

Comment 5

[Frank Tang]

shanjian- can you take a look at this ?

Comment 6

[Shanjian Li]

I could reproduce it yesterday, but not today after I update the source tree. I 
assume the bug was gone. Reopen the bug if you still see problem.

Comment 7

[Teruko Kobayashi]

I see this in 2001-03-01-10 Win32 with NT.

Comment 8

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 9

[Shanjian Li]

This problem is related with bug65963, most likely a duplicate. However, I have 
problem in reproducing any of those in my debug env. 

Comment 10

[Frank Tang]

jbetak- please take a look at it.

Comment 11

[[e-mail] (away - not reading bugmail)]

essentially same issue as 67623

Comment 12

[[e-mail] (away - not reading bugmail)]

I was able to reproduce consistenly using build 2001032804. Creating a new 
profile while leaving all charset-related settings on their default value does 
the trick for me.

Bugs 65963, 67623 and 60406 are all related. I'm hesitant to mark them as dups 
now. We might want to do so, when additional information becomes available.

Comment 13

[[e-mail] (away - not reading bugmail)]

another update on repro: the critical element seems to be "My Sidebar". 

1) visit http://gemal1.sprawl.dk/
2) turn on and off your sidebar
3) Tasks->Tools->JavaScript Console
3) View->Character Coding (get error in the JS Console)
4) View->Character Coding->Auto-Detect (get same error for different submenu in 
the JS Console)

Please note that in 3) and 4) nothing will be selected from the menu. The error 
gets thrown when opening the respective submenus.

Comment 14

[[e-mail] (away - not reading bugmail)]

Hm, since I'm doing some related work on charsetOverlay.js for bug 74680 and 
bug 73881 and wanted to address this bug also and found that 
http://gemal1.sprawl.dk/ is no longer accessible. I'm looking into similar 
sites, it would really help me, if someone had an alternate test site. Gemal, 
are you still following this?

Comment 15

[[e-mail] (away - not reading bugmail)]

marking dependency on bug 73881 and bug 78290. If we moved the checkmark update 
code fully into RDF (nsCharsetMenu.cpp), we could retire the function 
UpdateCurrentCharset() in charsetOverlay.js. It would obviously also address 
this bug...

Comment 16

[[e-mail] (away - not reading bugmail)]

adding a replacement URL for http://gemal1.sprawl.dk/

here are the updated repro steps:

1) visit http://webmail.redbox.cz/
2) turn on and off your sidebar
3) Tasks->Tools->JavaScript Console
3) View->Character Coding (get error in the JS Console)
4) View->Character Coding->Auto-Detect (get same error for different submenu in 
the JS Console)

Comment 17

[[e-mail] (away - not reading bugmail)]

still present in the 20010501 build. Looks like the main browser window loses
focus when the sidebar is turned on and off. When clicking the main window or
its navigational elements it regains focus and the warning goes away. The
previous comment on moving this functionality into nsCharsetMenu.cpp still applies.

Comment 18

[[e-mail] (away - not reading bugmail)]

Attachment: cvs diff -u xpfe/global/resources/content

Comment 19

[[e-mail] (away - not reading bugmail)]

I just created a patch - Naoki would you care to review? 

I'll try to get a sr and check the fix in this week. How is it with 
regressions - since we know that the function UpdateCurrentCharset() will go 
away, should we file a tracking bug for it?

Gemal, are you still following this? What is your view?

Comment 20

[[e-mail] (away - not reading bugmail)]

Attachment: cvs diff -u -b -u xpfe/global/resources/content

Comment 21

[nhottanscp]

Is that possible to call window._content.focus()?

Comment 22

[[e-mail] (away - not reading bugmail)]

Attachment: This gets around the lost focus better...

Comment 23

[[e-mail] (away - not reading bugmail)]

The problem is that document.commandDispatcher.focusedWindow return a null, 
which seems odd to me. 

However, your comment made me try something less obvious. It seems to work much 
better; it actually updates the charset menu checkmark when the browser window 
is out of focus, instead of just avoiding the warning.

Comment 24

[nhottanscp]

r=nhotta

Do you still need "if (wnd)" (i.e. can "window._content" be null)?

Comment 25

[[e-mail] (away - not reading bugmail)]

Attachment: eliminating "if (wnd)"

Comment 26

[[e-mail] (away - not reading bugmail)]

alecf, would you care to do a painless sr for a change?

Comment 27

[Alec Flett]

whee
sr=alecf

Comment 28

[[e-mail] (away - not reading bugmail)]

And another one bites the dust... Thanks everyone!

Comment 29

[Jon Rubin]

Verified on:
MacOS9.1 using 2001052405
WinMe-Ja using 2001052904
RH Linux7.0-Ja using 2001052205