Closed Bug 604149 Opened 9 years ago Closed 9 years ago

Render pages at 100% scale by default in landscape mode

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch set pageFitGranularity to 5 (obsolete) — Splinter Review
Chris Jones points out some reasons that we shouldn't autozoom to fit pages in landscape orientation:
http://groups.google.com/group/mozilla.dev.platforms.mobile/browse_thread/thread/704b397dcd1da0c9#

This patch changes the pageFitGranularity pref to 5, so pages up to 1000px wide will be rendered at 100% scale by default in landscape mode.  (The default viewport width in Fennec is 980px, so most pages are 980px wide.)
Attachment #482945 - Flags: review?(mark.finkle)
Thanks Matt.  Requesting blocking for obvious selfish reasons, but seems pretty safe for b2.
tracking-fennec: --- → ?
Comment on attachment 482945 [details] [diff] [review]
set pageFitGranularity to 5

this isn't a patch
oops
Attachment #482945 - Attachment is obsolete: true
Attachment #482955 - Flags: review?(mark.finkle)
Attachment #482945 - Flags: review?(mark.finkle)
Comment on attachment 482955 [details] [diff] [review]
set pageFitGranularity to 5 (correct patch)

Let's land this for b2 and see what the effect is on general browsing. Stuart had strong feelings for auto-zooming.
Attachment #482955 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → 2.0b2+
http://hg.mozilla.org/mobile-browser/rev/9d4b051f0f0f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101014 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101014 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Flags: in-litmus? → in-litmus?(martijn.martijn)
tracking-fennec: 2.0b2+ → ---
Flags: in-litmus?(martijn.martijn)
You need to log in before you can comment on or make changes to this bug.