Closed
Bug 604160
Opened 15 years ago
Closed 15 years ago
nsGeoPosition.h:136: warning: 'nsGeoPosition::mCoords' will be initialized after [...] nsGeoPosition::mTimestamp
Categories
(Core :: DOM: Geolocation, defect)
Core
DOM: Geolocation
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.24 KB,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h: In constructor 'nsGeoPosition::nsGeoPosition(nsIDOMGeoPositionCoords*, long long int)':
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h:136: warning: 'nsGeoPosition::mCoords' will be initialized after
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h:135: warning: 'long long int nsGeoPosition::mTimestamp'
../../../../mozilla/dom/src/geolocation/nsGeoPosition.cpp:245: warning: when initialized here
Trivial fix - just need to initialize mCoords after mTimestamp in the initializer list at nsGeoPosition.cpp:245
|
Assignee | |
Comment 1•15 years ago
|
||
This fixes the warning & removes an unnecessary null-check-after-new in contextual code. (since we've got infallible 'new' now)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #482947 -
Flags: review?(doug.turner)
Attachment #482947 -
Flags: approval2.0?
|
|
Assignee | |
Updated•15 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]
|
||
Comment 2•15 years ago
|
||
Comment on attachment 482947 [details] [diff] [review]
fix
low risk, fixes build warnings.
Attachment #482947 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•15 years ago
|
Attachment #482947 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•15 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•