nsGeoPosition.h:136: warning: 'nsGeoPosition::mCoords' will be initialized after [...] nsGeoPosition::mTimestamp

RESOLVED FIXED in mozilla2.0b7

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla2.0b7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h: In constructor 'nsGeoPosition::nsGeoPosition(nsIDOMGeoPositionCoords*, long long int)':
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h:136: warning: 'nsGeoPosition::mCoords' will be initialized after
../../../../mozilla/dom/src/geolocation/nsGeoPosition.h:135: warning:   'long long int nsGeoPosition::mTimestamp'
../../../../mozilla/dom/src/geolocation/nsGeoPosition.cpp:245: warning:   when initialized here

Trivial fix - just need to initialize mCoords after mTimestamp in the initializer list at nsGeoPosition.cpp:245
(Assignee)

Comment 1

8 years ago
Created attachment 482947 [details] [diff] [review]
fix

This fixes the warning & removes an unnecessary null-check-after-new in contextual code. (since we've got infallible 'new' now)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Updated

8 years ago
Attachment #482947 - Flags: review?(doug.turner)
Attachment #482947 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]

Comment 2

8 years ago
Comment on attachment 482947 [details] [diff] [review]
fix

low risk, fixes build warnings.
Attachment #482947 - Flags: approval2.0? → approval2.0+

Updated

8 years ago
Attachment #482947 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/6abe5c9ad11d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.