Closed Bug 604190 Opened 14 years ago Closed 14 years ago

nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: dholbert, Assigned: mstange)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

We get this build warning on non-MacOS:

> content/events/src/nsEventStateManager.cpp: At global scope:
> content/events/src/nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used

That static function is currently defined unconditionally, but is only called from an #ifdef XP_MACOSX block:

http://hg.mozilla.org/mozilla-central/diff/e18854fb9aed/content/events/src/nsEventStateManager.cpp

Warning easily fixable by adding an #ifdef XP_MACOSX around the method. (No point in defining it on platforms that don't use it.)
Attached patch v1Splinter Review
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #492351 - Flags: review?(Olli.Pettay)
Attachment #492351 - Flags: review?(Olli.Pettay) → review+
Attachment #492351 - Flags: approval2.0?
Attachment #492351 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/4fb1f137b0f6
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: