nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
DOM
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Assigned: mstange)

Tracking

Trunk
mozilla2.0b8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
We get this build warning on non-MacOS:

> content/events/src/nsEventStateManager.cpp: At global scope:
> content/events/src/nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used

That static function is currently defined unconditionally, but is only called from an #ifdef XP_MACOSX block:

http://hg.mozilla.org/mozilla-central/diff/e18854fb9aed/content/events/src/nsEventStateManager.cpp

Warning easily fixable by adding an #ifdef XP_MACOSX around the method. (No point in defining it on platforms that don't use it.)
(Assignee)

Comment 1

8 years ago
Created attachment 492351 [details] [diff] [review]
v1
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #492351 - Flags: review?(Olli.Pettay)

Updated

8 years ago
Attachment #492351 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

8 years ago
Attachment #492351 - Flags: approval2.0?

Updated

8 years ago
Attachment #492351 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/4fb1f137b0f6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.