604222 - Autolinking and html support for privacy policy/EULA

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://preview.addons.mozilla.org/z/en-US/developers/addon/228507/ownership
2. Add EULA and privacy policy with a URL and some html

expected result:
As per spec, autolinking and html is allowed for these fields.

Actual result:
We do not do auto linking and html support for these fields. check- 

https://preview.addons.mozilla.org/z/en-US/firefox/addon/228507/privacy/ 

https://preview.addons.mozilla.org/z/en-US/firefox/addon/228507/eula/98990?src=addondetail

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot

Comment 2

[Jeff Balogh (:jbalogh)]

Hint: s/TranslatedField/PurifiedField/

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

A mini-spec would be nice, too; do we support:

[1] <a href="mailto:[e-mail]>username</a>
[2] Original author <ego@invalid>.

From bug 493247, Original author <ego@invalid>. gets turned into "Original author <ego@invalid>.</ego@invalid>", and mailtos don't appear to be supported by outgoing.mozilla.com:

"You are about to log in to the site "mozilla.com" with the username "mailto", but the website does not require authentication. This may be an attempt to trick you.

Is "mozilla.com" the site you want to visit?"

Comment 5

[Kumar McMillan [:kumar]]

Stephen: The mailto issue would be a bug in outgoing.mozilla.org.  The <ego@invalid> behavior happens because the field allows HTML and that looks like invalid HTML to the parser so it gets fixed to <ego@invalid>.</ego@invalid>.  I'm not sure if we should do something about that or not.  Even so, it probably would work better in another bug.

For now, I have fixed the original issue here:
http://github.com/jbalogh/zamboni/commit/60f2283eedf74636967a02a9384a2b698e690969

And it's showing up on preview now:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/228507/privacy/
https://preview.addons.mozilla.org/z/en-US/firefox/addon/228507/eula/

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, Kumar: spun off comment 3 / comment 5 as bug 609269.

Comment 7

[krupa raj[:krupa]]

verified  at https://addons-next.allizom.org/z/en-US/firefox/addon/228515/eula/99017?src=addondetail
 and https://addons-next.allizom.org/z/en-US/firefox/addon/228515/eula/99017?src=addondetail

Autolinking works and a few HTML tags like <ol>,<ul> and <blockquote> work fine. 

Issues with specific HTML tags will be filed as new bugs. Issue from comment #3, will be filed as a new bug.

I also filed bug 609164