Closed
Bug 604316
Opened 14 years ago
Closed 14 years ago
Duplicate access key 'B' for Add-on Bar in [View] -> [Toolbars]
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
VERIFIED
FIXED
Firefox 4.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: masayuki, Assigned: dietrich)
References
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
dao
:
review+
Pike
:
feedback+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Looks like "Add-on Bar" and "Bookmarks Toolbar" are using 'B' for their mnemonic. I think that "Add-on Bar" should use 'A'.
|
Reporter | |
Updated•14 years ago
|
OS: Windows 7 → All
Hardware: x86 → All
|
||
Comment 1•14 years ago
|
||
'B' has been chosen in the initial patch by dietrich. Adding dependency.
Blocks: 574688
blocking2.0: --- → ?
Summary: Conflict mnemonics in [View] -> [Toolbars] → Duplicate access key 'B' in [View] -> [Toolbars]
|
|
||
Updated•14 years ago
|
Summary: Duplicate access key 'B' in [View] -> [Toolbars] → Duplicate access key 'B' for Add-on Bar in [View] -> [Toolbars]
|
||
Comment 2•14 years ago
|
||
I agree it should be 'A'.
|
|
||
Updated•14 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 4•14 years ago
|
||
Assignee: nobody → dietrich
Attachment #486002 -
Flags: review?(dao)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #486002 -
Flags: feedback?(l10n)
|
||
Updated•14 years ago
|
Attachment #486002 -
Flags: review?(dao) → review+
|
||
Updated•14 years ago
|
Attachment #486002 -
Flags: feedback?(l10n) → feedback+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #486002 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #486002 -
Flags: approval2.0? → approval2.0+
|
||
Comment 5•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/132b6e95d9db
Status: NEW → RESOLVED
blocking2.0: ? → -
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
|
|
||
Comment 6•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
This bug still exists in Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101115 Firefox/4.0b8pre en_GB
|
|
||
Comment 8•14 years ago
|
||
(In reply to comment #7) > This bug still exists in > Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101115 Firefox/4.0b8pre > en_GB Then it should be fixed in the en_GB localization. It's independent from en_US.
|
|
||
Comment 9•14 years ago
|
||
Comment on attachment 486002 [details] [diff] [review] v1 >-<!ENTITY addonBarCmd.accesskey "B"> >+<!ENTITY addonBarCmd.accesskey "A"> Axel, should we send out an email to the l10n list? Because the entity name hasn't been changed, no other locale will notice this change.
|
|
||
Comment 10•14 years ago
|
||
Yeah, seems like it's much more frequent than I thought, looking at http://mxr.mozilla.org/l10n-central/search?string=addonBarCmd.accesskey&find=browser%2Fbrowser.dtd&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central
You need to log in
before you can comment on or make changes to this bug.
Description
•