Closed Bug 604337 Opened 11 years ago Closed 11 years ago

Build/tool's l10n.py assumes a Firefox specific location for shipped-locales

Categories

(Release Engineering :: General, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: bhearsum)

References

Details

(Whiteboard: [l10n])

Attachments

(2 files)

Bug 399095 recently added some changes but hard-coded the location for shipped-locales:

http://hg.mozilla.org/build/tools/file/911c93dcc345/lib/python/release/l10n.py#l9

file = '%s/raw-file/%s/browser/locales/shipped-locales' % \
       (sourceRepo, tag)

This, of course, breaks non-Firefox builds.
(In reply to comment #0)
> file = '%s/raw-file/%s/browser/locales/shipped-locales' % \
>        (sourceRepo, tag)

(and to be clear, Thunderbird uses /mail/ and SeaMonkey uses /suite/).
D'oh, we need to be passing in appName here.
Assignee: nobody → bhearsum
Looks like you guys accidentally changed the hardcoding in http://hg.mozilla.org/build/tools/rev/5b9cd99b3f78, I've backed that out. I'll provide a real fix shortly.
(In reply to comment #3)
> Looks like you guys accidentally changed the hardcoding in
> http://hg.mozilla.org/build/tools/rev/5b9cd99b3f78, I've backed that out. I'll
> provide a real fix shortly.

Oops, thanks - that was my local fix being pushed by mistake.
Whiteboard: [l10n]
Attachment #483143 - Flags: review?(rail)
Attachment #483143 - Flags: review?(rail) → review+
Attachment #483144 - Flags: review?(rail) → review+
This tested fine in staging. Going to wait until 553300 lands to land this.
Depends on: 553300
Comment on attachment 483143 [details] [diff] [review]
pass in appName to script

changeset:   938:cb41c45ae30f
Attachment #483143 - Flags: checked-in+
Comment on attachment 483144 [details] [diff] [review]
pass appName to script in factory

Landed this on 0.8.0 and default:
0.8.0: changeset:   1090:b0da779cfbca
default: changeset:   1091:c72c38aaff61
Attachment #483144 - Flags: checked-in+
Should be fixed now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.