604359 - Switch more character encodings to better default fonts

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Rain [:rain1] (inactive)]

This is a followup to bug 465633. See <http://groups.google.com/group/mozilla.dev.l10n/browse_thread/thread/4d786169e6bb3aa1> and <https://mail.mozilla.org/pipermail/tb-planning/2010-October/000530.html>.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch

Baltic and Greek seem ok going by the m.d.l10n thread, and I've optimistically switched the others too.

(Note that if you run the test in isolation on Windows you'll hit bug 604406 and will need the patch there.)

Comment 2

[Rain [:rain1] (inactive)]

(In reply to comment #1)
> you'll hit bug 604406

Change that to "you might". The output contains the path to the test.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 483189 [details] [diff] [review]
patch

sounds good to me!

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 483189 [details] [diff] [review]
patch

>+++ b/mail/base/test/unit/test_windows_font_migration.js
>@@ -247,79 +263,132 @@ function test_not_migrating_monospace(aV
> /**
>  * Test migrating from the default fonts but from font sizes that aren't so.
>  */
> function test_migrating_non_default_font_sizes(aVerifier) {
>   gPrefBranch.setIntPref("font.size.variable.x-unicode", 20);
>   gPrefBranch.setIntPref("font.size.fixed.x-western", 30);
>+  gPrefBranch.setIntPref("font.size.variable.x-central-euro", 40);
> 
>   MailMigrator.migrateToClearTypeFonts();
> 
>   aVerifier("x-unicode", {variableSizeNonMigrated: 20});
>   aVerifier("x-western", {fixedSizeNonMigrated: 30});
>+  aVerifier("x-central-euro", {variableSizeNonMigrated: 40});
>+  aVerifier("x-cyrillic", null);
>+  aVerifier("x-baltic", null);
>+  aVerifier("el", null);
>+  aVerifier("tr", null);

The only thing I might do here is to choose one of the ones further down to not migrate, in case we set a flag when we start migrating things that we forget to clear.  (I doubt we do, but choosing "el" seems more random to me than choosing "x-central-euro".)

Other than that, r=me.

Later,
Blake.

Comment 5

[Rain [:rain1] (inactive)]

Attachment: patch addressing review nit, to check in

I decided to test every locale instead. :)

Comment 6

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/4ced037493a5
http://hg.mozilla.org/comm-central/rev/66715bcebc09

Comment 7

[Rain [:rain1] (inactive)]

Pushed a followup: https://hg.mozilla.org/comm-central/rev/61ed148c85cd